[jira] Commented: (JCR-509) TCK: NodeTest#testNodeIdentity fails if versioning and locking not supported

["Marcel Reutegger (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/JCR-509?page=comments#action_12425244 ] 
            
Marcel Reutegger commented on JCR-509:
--------------------------------------

The two methods Node.isCheckedOut() and Node.isLocked() are specified to also work on non-versionable and non-lockable nodes. Therefore I assume that Node.isCheckedOut() must return true if the repository does not support versioning and Node.isLocked() must return false if the repository does not support locking.

Is there a section in the specification that talks about those two methods and allows them to throw an exception in such a case?

> TCK: NodeTest#testNodeIdentity fails if versioning and locking not supported
> ----------------------------------------------------------------------------
>
>                 Key: JCR-509
>                 URL: http://issues.apache.org/jira/browse/JCR-509
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: test
>            Reporter: David Pitfield
>
> The test calls isCheckedOut and isLocked without testing whether versioning and locking are supported.
> Proposal: call isCheckedOut only if versioning is supported; call isLocked only if locking is supported.
> --- NodeTest.java       (revision 422074)
> +++ NodeTest.java       (working copy)
> @@ -757,8 +769,12 @@
>          // check if they have the same child
>          assertEquals("Two references of same node have different children", testNode1.getNode(nodeName1), testNode2.getNode(nodeName1));
>          // check state methods
> -        assertEquals("Two references of same node have different State for Node.isCheckedOut()", testNode1.isCheckedOut(), testNode2.isCheckedOut());
> -        assertEquals("Two references of same node have different State for Node.isLocked()", testNode1.isLocked(), testNode2.isLocked());
> +        if (isSupported(Repository.OPTION_VERSIONING_SUPPORTED)) {
> +          assertEquals("Two references of same node have different State for Node.isCheckedOut()", testNode1.isCheckedOut(), testNode2.isCheckedOut());
> +        }
> +        if (isSupported(Repository.OPTION_LOCKING_SUPPORTED)) {
> +          assertEquals("Two references of same node have different State for Node.isLocked()", testNode1.isLocked(), testNode2.isLocked());
> +        }
>          assertEquals("Two references of same node have different State for Node.isModified()", testNode1.isModified(), testNode2.isModified());
>          assertEquals("Two references of same node have different State for Node.isNew()", testNode1.isNew(), testNode2.isNew());
>          assertEquals("Two references of same node have different State for Node.isNode()", testNode1.isNode(), testNode2.isNode());

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira