You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/09/05 20:39:52 UTC

[GitHub] [cloudstack] shwstppr opened a new pull request, #6707: ui: fix set reservation toggle in add public ip range

shwstppr opened a new pull request, #6707:
URL: https://github.com/apache/cloudstack/pull/6707

   ### Description
   
   Fixes 'Set reservation' toggle not getting updated on value change.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr merged pull request #6707: ui: fix set reservation toggle in add public ip range

Posted by GitBox <gi...@apache.org>.
shwstppr merged PR #6707:
URL: https://github.com/apache/cloudstack/pull/6707


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] acs-robot commented on pull request #6707: ui: fix set reservation toggle in add public ip range

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6707:
URL: https://github.com/apache/cloudstack/pull/6707#issuecomment-1237447059

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6707: ui: fix set reservation toggle in add public ip range

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6707:
URL: https://github.com/apache/cloudstack/pull/6707#issuecomment-1237449819

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6707 (SL-JID-2294)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6707: ui: fix set reservation toggle in add public ip range

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6707:
URL: https://github.com/apache/cloudstack/pull/6707#issuecomment-1237447174

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6707: ui: fix set reservation toggle in add public ip range

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6707:
URL: https://github.com/apache/cloudstack/pull/6707#issuecomment-1237471399

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6707)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6707&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6707&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6707&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6707&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6707&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6707&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6707&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6707&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6707&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6707&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6707&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6707&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6707&metric=coverage&view=list) No Coverage information  
   [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6707&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] codecov[bot] commented on pull request #6707: ui: fix set reservation toggle in add public ip range

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6707:
URL: https://github.com/apache/cloudstack/pull/6707#issuecomment-1237520593

   # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6707?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#6707](https://codecov.io/gh/apache/cloudstack/pull/6707?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0ebcb70) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/c290cbcb71e80910c4ef22149803d758f13afbc6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c290cbc) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##               4.17    #6707   +/-   ##
   =========================================
     Coverage      5.87%    5.88%           
   + Complexity     3928     3926    -2     
   =========================================
     Files          2451     2451           
     Lines        242312   242312           
     Branches      37920    37920           
   =========================================
   + Hits          14239    14251   +12     
   + Misses       226499   226486   -13     
   - Partials       1574     1575    +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6707?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/6707/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `56.49% <0.00%> (-2.26%)` | :arrow_down: |
   | [.../network/lb/InternalLoadBalancerVMManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6707/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2ludGVybmFsLWxvYWRiYWxhbmNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9uZXR3b3JrL2xiL0ludGVybmFsTG9hZEJhbGFuY2VyVk1NYW5hZ2VySW1wbC5qYXZh) | `25.05% <0.00%> (+0.46%)` | :arrow_up: |
   | [.../org/apache/cloudstack/ldap/LdapAuthenticator.java](https://codecov.io/gh/apache/cloudstack/pull/6707/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy91c2VyLWF1dGhlbnRpY2F0b3JzL2xkYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbGRhcC9MZGFwQXV0aGVudGljYXRvci5qYXZh) | `23.91% <0.00%> (+0.72%)` | :arrow_up: |
   | [...rc/main/java/com/cloud/deploy/FirstFitPlanner.java](https://codecov.io/gh/apache/cloudstack/pull/6707/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2RlcGxveS9GaXJzdEZpdFBsYW5uZXIuamF2YQ==) | `28.09% <0.00%> (+0.82%)` | :arrow_up: |
   | [...loudstack/server/auth/PBKDF2UserAuthenticator.java](https://codecov.io/gh/apache/cloudstack/pull/6707/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy91c2VyLWF1dGhlbnRpY2F0b3JzL3Bia2RmMi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9zZXJ2ZXIvYXV0aC9QQktERjJVc2VyQXV0aGVudGljYXRvci5qYXZh) | `51.78% <0.00%> (+1.78%)` | :arrow_up: |
   | [...oud/server/auth/SHA256SaltedUserAuthenticator.java](https://codecov.io/gh/apache/cloudstack/pull/6707/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy91c2VyLWF1dGhlbnRpY2F0b3JzL3NoYTI1NnNhbHRlZC9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9zZXJ2ZXIvYXV0aC9TSEEyNTZTYWx0ZWRVc2VyQXV0aGVudGljYXRvci5qYXZh) | `69.09% <0.00%> (+1.81%)` | :arrow_up: |
   | [...pper/LibvirtPrepareForMigrationCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/6707/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0UHJlcGFyZUZvck1pZ3JhdGlvbkNvbW1hbmRXcmFwcGVyLmphdmE=) | `53.19% <0.00%> (+2.12%)` | :arrow_up: |
   | [...pper/xenbase/CitrixCheckNetworkCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/6707/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy94ZW5zZXJ2ZXIvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci94ZW5zZXJ2ZXIvcmVzb3VyY2Uvd3JhcHBlci94ZW5iYXNlL0NpdHJpeENoZWNrTmV0d29ya0NvbW1hbmRXcmFwcGVyLmphdmE=) | `46.15% <0.00%> (+2.56%)` | :arrow_up: |
   | [...va/com/cloud/server/auth/MD5UserAuthenticator.java](https://codecov.io/gh/apache/cloudstack/pull/6707/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy91c2VyLWF1dGhlbnRpY2F0b3JzL21kNS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9zZXJ2ZXIvYXV0aC9NRDVVc2VyQXV0aGVudGljYXRvci5qYXZh) | `70.37% <0.00%> (+3.70%)` | :arrow_up: |
   | [...nbase/CitrixPrepareForMigrationCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/6707/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy94ZW5zZXJ2ZXIvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci94ZW5zZXJ2ZXIvcmVzb3VyY2Uvd3JhcHBlci94ZW5iYXNlL0NpdHJpeFByZXBhcmVGb3JNaWdyYXRpb25Db21tYW5kV3JhcHBlci5qYXZh) | `63.15% <0.00%> (+5.26%)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/cloudstack/pull/6707/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org