You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by fidelchen <gi...@git.apache.org> on 2014/05/18 15:29:19 UTC
[GitHub] thrift pull request: Update t_cpp_generator.cc
GitHub user fidelchen opened a pull request:
https://github.com/apache/thrift/pull/123
Update t_cpp_generator.cc
for std::greater
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fidelchen/thrift patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/123.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #123
----
commit 38509a23d4f471ad309669b06036bcd670ac2ac7
Author: fidelchen <90...@qq.com>
Date: 2014-05-18T13:29:08Z
Update t_cpp_generator.cc
for std::greater
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Update t_cpp_generator.cc
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/123#issuecomment-57365455
@fidelchen : You may find this helpful as well: http://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Update t_cpp_generator.cc
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/123
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Update t_cpp_generator.cc
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/123#issuecomment-93615874
Thanks for your patch @fidelchen, in order for us to accept a pull request we need to have a jira ticket associated with it. Please see our contributing guide at http://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Update t_cpp_generator.cc
Posted by hcorg <gi...@git.apache.org>.
Github user hcorg commented on the pull request:
https://github.com/apache/thrift/pull/123#issuecomment-57352797
1. Please create Jira issue https://issues.apache.org/jira/browse/THRIFT
2. this pull request contains only half of needed change - only operator> declaration is generated, no definiton
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---