[GitHub] [geode-native] echobravopapa commented on a change in pull request #864: GEODE-9576: Fix for single-hop function execution

[GitBox <gi...@apache.org>]

echobravopapa commented on a change in pull request #864:
URL: https://github.com/apache/geode-native/pull/864#discussion_r705531306



##########
File path: cppcache/src/ClientMetadataService.cpp
##########
@@ -578,12 +579,10 @@ ClientMetadataService::pruneNodes(
     const auto locations = metadata->adviseServerLocations(bucketId);
     if (locations.size() == 0) {
       LOGDEBUG(
-          "ClientMetadataService::pruneNodes Since no server location "
-          "available for bucketId = %d  putting it into "
-          "bucketSetWithoutServer ",
+          "ClientMetadataService::pruneNodes Use non single-hop path "
+          "since no server location is available for bucketId = %d",
           bucketId);
-      bucketSetWithoutServer.insert(bucketId);
-      continue;
+      return nullptr;

Review comment:
       I'd like to see an integration test that exposes the issue being fixed...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org