[GitHub] [airflow] Taragolis commented on a diff in pull request #34320: Refactor usage of str() in providers

["Taragolis (via GitHub)" <gi...@apache.org>]

Taragolis commented on code in PR #34320:
URL: https://github.com/apache/airflow/pull/34320#discussion_r1323637079


##########
tests/providers/qubole/operators/test_qubole_check.py:
##########


Review Comment:
   Suspended provider



##########
airflow/providers/common/sql/operators/sql.py:
##########
@@ -945,8 +945,8 @@ def __init__(
         sqlexp = ", ".join(self.metrics_sorted)
         sqlt = f"SELECT {sqlexp} FROM {table} WHERE {date_filter_column}="
 
-        self.sql1 = sqlt + "'{{ ds }}'"
-        self.sql2 = sqlt + "'{{ macros.ds_add(ds, " + str(self.days_back) + ") }}'"
+        self.sql1 = f"{sqlt}'{{ ds }}'"

Review Comment:
   ```suggestion
           self.sql1 = f"{sqlt}'{{{{ ds }}}}'"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org