You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2018/11/11 07:58:39 UTC
svn commit: r1846336 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java
Author: tilman
Date: Sun Nov 11 07:58:39 2018
New Revision: 1846336
URL: http://svn.apache.org/viewvc?rev=1846336&view=rev
Log:
PDFBOX-4375: use a Set instead of a Map
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java?rev=1846336&r1=1846335&r2=1846336&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java Sun Nov 11 07:58:39 2018
@@ -25,8 +25,10 @@ import java.io.OutputStream;
import java.math.BigDecimal;
import java.util.ArrayList;
import java.util.HashMap;
+import java.util.HashSet;
import java.util.List;
import java.util.Map;
+import java.util.Set;
import org.apache.pdfbox.cos.COSArray;
import org.apache.pdfbox.cos.COSBase;
import org.apache.pdfbox.cos.COSDictionary;
@@ -62,7 +64,7 @@ public class Overlay implements Closeabl
private LayoutPage oddPageOverlayPage;
private LayoutPage evenPageOverlayPage;
- private final Map<Integer, PDDocument> openDocumentsMap = new HashMap<>();
+ private final Set<PDDocument> openDocuments = new HashSet<PDDocument>();
private Map<Integer, LayoutPage> specificPageOverlayPage = new HashMap<>();
private Position position = Position.BACKGROUND;
@@ -117,7 +119,7 @@ public class Overlay implements Closeabl
loadedDocuments.put(e.getValue(), doc);
layouts.put(doc, getLayoutPage(doc));
}
- openDocumentsMap.put(e.getKey(), doc);
+ openDocuments.add(doc);
specificPageOverlayPage.put(e.getKey(), layouts.get(doc));
}
processPages(inputPDFDocument);
@@ -156,11 +158,11 @@ public class Overlay implements Closeabl
{
evenPageOverlay.close();
}
- for (PDDocument doc : openDocumentsMap.values())
+ for (PDDocument doc : openDocuments)
{
doc.close();
}
- openDocumentsMap.clear();
+ openDocuments.clear();
specificPageOverlayPage.clear();
}