You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "falser101 (via GitHub)" <gi...@apache.org> on 2025/08/05 05:59:01 UTC
[PR] Fix/issue 24585 [pulsar]
falser101 opened a new pull request, #24604:
URL: https://github.com/apache/pulsar/pull/24604
<!-- Either this PR fixes an issue, -->
Fixes #24585
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][io] Add dependency file name information to error message when .nar file validation fails with ZipException [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #24604:
URL: https://github.com/apache/pulsar/pull/24604#discussion_r2253328467
##########
pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionFilePackage.java:
##########
@@ -79,7 +79,7 @@ public FunctionFilePackage(File file, String narExtractionDirectory, boolean ena
}
classFileLocators.add(locator);
} catch (IOException e) {
- throw new UncheckedIOException(e);
+ throw new UncheckedIOException(new IOException("Loading '" + classpath + "' failed due to " + e.getMessage(), e));
Review Comment:
```suggestion
throw new UncheckedIOException("Loading '" + classpath + "' failed due to " + e.getMessage(), e);
```
There's no need to wrap the exception in yet another nested IOException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][io] Add dependency file name information to error message when .nar file validation fails with ZipException [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #24604:
URL: https://github.com/apache/pulsar/pull/24604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][io] Add dependency file name information to error message when .nar file validation fails with ZipException [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #24604:
URL: https://github.com/apache/pulsar/pull/24604#issuecomment-3164415249
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][io] Add dependency file name information to error message when .nar file validation fails with ZipException [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #24604:
URL: https://github.com/apache/pulsar/pull/24604#issuecomment-3158508759
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][io] Add dependency file name information to error message when .nar file validation fails with ZipException [pulsar]
Posted by "falser101 (via GitHub)" <gi...@apache.org>.
falser101 commented on PR #24604:
URL: https://github.com/apache/pulsar/pull/24604#issuecomment-3153507357
@lhotari
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][io] Add dependency file name information to error message when .nar file validation fails with ZipException [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24604:
URL: https://github.com/apache/pulsar/pull/24604#issuecomment-3164799186
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24604?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.29%. Comparing base ([`fa28d1c`](https://app.codecov.io/gh/apache/pulsar/commit/fa28d1c1ef1611bf164d036628b3a5a6dc52adfc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9751298`](https://app.codecov.io/gh/apache/pulsar/commit/9751298c6c6fe255783e3dd36c3ff674f0276890?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/24604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #24604 +/- ##
============================================
- Coverage 74.53% 74.29% -0.24%
- Complexity 32769 33150 +381
============================================
Files 1880 1881 +1
Lines 146433 146776 +343
Branches 16789 16857 +68
============================================
- Hits 109141 109048 -93
- Misses 28697 29070 +373
- Partials 8595 8658 +63
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/24604/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/24604/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.67% <0.00%> (-0.68%)` | :arrow_down: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/24604/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.29% <0.00%> (-0.17%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/24604/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.77% <100.00%> (-0.25%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/pulsar/pull/24604?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...he/pulsar/functions/utils/FunctionFilePackage.java](https://app.codecov.io/gh/apache/pulsar/pull/24604?src=pr&el=tree&filepath=pulsar-functions%2Futils%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Ffunctions%2Futils%2FFunctionFilePackage.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWZ1bmN0aW9ucy91dGlscy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Z1bmN0aW9ucy91dGlscy9GdW5jdGlvbkZpbGVQYWNrYWdlLmphdmE=) | `71.42% <100.00%> (+2.85%)` | :arrow_up: |
... and [99 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/24604/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org