svn commit: r1023883 - in /wicket/trunk: wicket-request/src/main/java/org/apache/wicket/request/mapper/AbstractMapper.java wicket/src/main/java/org/apache/wicket/request/mapper/HomePageMapper.java

[mg...@apache.org]

Author: mgrigorov
Date: Mon Oct 18 16:17:47 2010
New Revision: 1023883

URL: http://svn.apache.org/viewvc?rev=1023883&view=rev
Log:
Add a comment to HomePageMapper that it doesn't handle generation of Url for IRequestHandler's

If the user application wants to preserve '/' as url then it must mount it explicitly in MyApplication#init()

Idea: we could do that automatically in #internalInit() and remove completely HomePageMapper.

Remove the check in AbstractMapper because otherwise it is not possible to mount at '/'

Modified:
    wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/AbstractMapper.java
    wicket/trunk/wicket/src/main/java/org/apache/wicket/request/mapper/HomePageMapper.java

Modified: wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/AbstractMapper.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/AbstractMapper.java?rev=1023883&r1=1023882&r2=1023883&view=diff
==============================================================================
--- wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/AbstractMapper.java (original)
+++ wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/AbstractMapper.java Mon Oct 18 16:17:47 2010
@@ -189,11 +189,6 @@ public abstract class AbstractMapper
 		}
 		Url url = Url.parse(mountPath);
 
-		if (url.getSegments().isEmpty())
-		{
-			throw new IllegalArgumentException("Mount path must have at least one segment.");
-		}
-
 		String[] res = new String[url.getSegments().size()];
 		for (int i = 0; i < res.length; ++i)
 		{

Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/request/mapper/HomePageMapper.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/request/mapper/HomePageMapper.java?rev=1023883&r1=1023882&r2=1023883&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/request/mapper/HomePageMapper.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/request/mapper/HomePageMapper.java Mon Oct 18 16:17:47 2010
@@ -16,6 +16,7 @@
  */
 package org.apache.wicket.request.mapper;
 
+import org.apache.wicket.Application;
 import org.apache.wicket.request.IRequestHandler;
 import org.apache.wicket.request.Request;
 import org.apache.wicket.request.Url;
@@ -28,7 +29,12 @@ import org.apache.wicket.request.mapper.
 import org.apache.wicket.util.lang.Args;
 
 /**
- * Mapper for rendering home page.
+ * Default mapper for rendering the configured {@link Application#getHomePage() home page}.
+ * <p>
+ * <strong>Note</strong>: Handles requests to '/' but does not produce {@link Url} for it, thus
+ * {@link BookmarkableMapper} produces something like '/wicket/bookmarkable/com.example.MyHomePage'
+ * for it. If the user application wants to preserve '/' then it should mount the home page
+ * explicitly in MyApplication#init()
  * 
  * @author Matej Knopp
  */