[GitHub] [incubator-zipkin-brave] anuraaga commented on issue #609: Don't make spans for comments or SET statements in SQL

[GitBox <gi...@apache.org>]

anuraaga commented on issue #609: Don't make spans for comments or SET statements in SQL
URL: https://github.com/apache/incubator-zipkin-brave/issues/609#issuecomment-492227331
 
 
   A few observations
   
   - `/*` should never be the name of a span. I suspect the MySQL instrumentation needs to be updated to handle this more sanely. FWIW, I don't think I've ever seen this I wonder if there is a connector option pretending that comment
   
   - Traces of background spans like `SET` and health check have always been annoying. I'm only interested in tracing queries in the context of a request (if you know what I mean ;) so HikariCP's background queries are boring.
   
   - Unfortunately it's not as simple as filtering the span name by itself. Select used in health check I don't need but select used by the app I do.
   
   It's not clear to me whether decoration etc have the flexibility for this sort of filtering. Though I don't know if an interceptor option does either - it's really a pain that MySQL connector doesn't use the perfectly good service loader mechanism for extension... I think we'd need to play around to see what ends up cleanest. 
   
   But definitely want to help getting rid of junk MySQL spans from my apps!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org