You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tooling.apache.org by "sebbASF (via GitHub)" <gi...@apache.org> on 2025/06/12 16:00:00 UTC
[I] Compose allows Voting even if no files have been uploaded (tooling-trusted-release)
sebbASF opened a new issue, #160:
URL: https://github.com/apache/tooling-trusted-release/issues/160
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] Compose allows Voting even if no files have been uploaded (tooling-trusted-release)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #160:
URL: https://github.com/apache/tooling-trusted-release/issues/160#issuecomment-2985456484
Thanks for the report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] Compose allows Voting even if no files have been uploaded (tooling-trusted-release)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp closed issue #160: Compose allows Voting even if no files have been uploaded
URL: https://github.com/apache/tooling-trusted-release/issues/160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] Compose allows Voting even if no files have been uploaded (tooling-trusted-release)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #160:
URL: https://github.com/apache/tooling-trusted-release/issues/160#issuecomment-3024127835
Resolved by 686810445e91690a00f06cbaf6f04840b8d240f2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] Compose allows Voting even if no files have been uploaded (tooling-trusted-release)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp closed issue #160: Compose allows Voting even if no files have been uploaded
URL: https://github.com/apache/tooling-trusted-release/issues/160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] Compose allows Voting even if no files have been uploaded (tooling-trusted-release)
Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on issue #160:
URL: https://github.com/apache/tooling-trusted-release/issues/160#issuecomment-3020711896
I found the experience with #3 to seem like a dead button. The flashed error looked like nothing happened
I think that there is
#4 Show a disabled **Start Voting** button.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] Compose allows Voting even if no files have been uploaded (tooling-trusted-release)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #160:
URL: https://github.com/apache/tooling-trusted-release/issues/160#issuecomment-2985409240
Resolved by c619eff44e576996057c64ef75d30d689f6bc45f.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] Compose allows Voting even if no files have been uploaded (tooling-trusted-release)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #160:
URL: https://github.com/apache/tooling-trusted-release/issues/160#issuecomment-2985358663
The form to start a vote is rendered when there are no files in the draft, but I get "**Error**: This candidate draft is empty, containing no files" upon submission. I assume this issue requests that the form not even be rendered if no files are present, and will implement that. If there was also a bug allowing the vote to start even after form submission, however, please let me know, as the new implementation hiding the form will make it difficult to test whether that was the case under certain conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] Compose allows Voting even if no files have been uploaded (tooling-trusted-release)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #160:
URL: https://github.com/apache/tooling-trusted-release/issues/160#issuecomment-2985402745
There were a few possible ways to fix this, in the scenario where there are no files in the draft:
1. Do not show the button to start the vote, and make the voting page raise an exception if accessed.
2. Retain the button to show the vote, but show an error on the vote form page instead of the form.
3. Retain the button to show the vote, but flash an error on the draft page when the button is pressed.
I've chosen the third as being the most user friendly, as the first way would make it less clear what needs to be done, and the second way means that the user has to navigate back to the place where they can fix the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org