You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "zhutong6688 (via GitHub)" <gi...@apache.org> on 2023/09/22 08:07:13 UTC
[GitHub] [dolphinscheduler] zhutong6688 opened a new pull request, #14954: [improvement][Resources] Improve details page return to the previous list page (#14951)
zhutong6688 opened a new pull request, #14954:
URL: https://github.com/apache/dolphinscheduler/pull/14954
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
Current Problem Is fix #14951 in any version of 3.1.x or 3.2.x or later version
The purpose of this modification is that when we are in the resource list, we click into the resource details page, and then return to the resource list, we can still return to the original resource list。
## Brief change log
base on dev branch
add main improve code in dolphinscheduler-ui/src/views/resource/components/resource/edit/index.tsx
add main improve code in dolphinscheduler-ui/src/views/resource/components/resource/edit/use-edit.ts
add main improve code in dolphinscheduler-ui/src/views/resource/components/resource/table/use-table.ts
add main improve code dolphinscheduler-ui/src/views/resource/components/resource/index.tsx
## Verify this pull request
This is the test verification of this improvement for problem #14951, as follows：
1、Query resource list unconditionally
2、Query resource list conditionally
As can be seen from the above, whether in the case of conditional or unconditional query of resource files, when you enter the corresponding resource details page and click Save or Return, you can smoothly return to the previous resource list, greatly improving the development efficiency. Otherwise, you will return to the home page every time and lose the query conditions, which greatly reduces the development efficiency。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improvement][Resources] Improve details page return to the previous list page (#14951) [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14954:
URL: https://github.com/apache/dolphinscheduler/pull/14954#issuecomment-1760691451
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=14954)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14954&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14954&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14954&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improvement][Resources] Improve details page return to the previous list page (#14951) [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS merged PR #14954:
URL: https://github.com/apache/dolphinscheduler/pull/14954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhutong6688 commented on pull request #14954: [improvement][Resources] Improve details page return to the previous list page (#14951)
Posted by "zhutong6688 (via GitHub)" <gi...@apache.org>.
zhutong6688 commented on PR #14954:
URL: https://github.com/apache/dolphinscheduler/pull/14954#issuecomment-1730999640
I use pinia to store data instead of using localStorage directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improvement][Resources] Improve details page return to the previous list page (#14951) [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14954:
URL: https://github.com/apache/dolphinscheduler/pull/14954#issuecomment-1760691035
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=14954)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14954&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14954&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14954&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14954&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improvement][Resources] Improve details page return to the previous list page (#14951) [dolphinscheduler]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #14954:
URL: https://github.com/apache/dolphinscheduler/pull/14954#issuecomment-1760685390
## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14954?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#14954](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14954?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (51c1923) into [dev](https://app.codecov.io/gh/apache/dolphinscheduler/commit/d983e36ea4fedd391cbed78067b1861e3daf122f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d983e36) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 51c1923 differs from pull request most recent head 0de348a. Consider uploading reports for the commit 0de348a to get more accurate results
```diff
@@ Coverage Diff @@
## dev #14954 +/- ##
============================================
- Coverage 38.90% 38.89% -0.02%
+ Complexity 4611 4609 -2
============================================
Files 1236 1236
Lines 43449 43415 -34
Branches 4809 4792 -17
============================================
- Hits 16905 16886 -19
+ Misses 24670 24656 -14
+ Partials 1874 1873 -1
```
[see 25 files with indirect coverage changes](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14954/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhutong6688 commented on pull request #14954: [improvement][Resources] Improve details page return to the previous list page (#14951)
Posted by "zhutong6688 (via GitHub)" <gi...@apache.org>.
zhutong6688 commented on PR #14954:
URL: https://github.com/apache/dolphinscheduler/pull/14954#issuecomment-1731002717
I have applied this optimization to the dolphin scheduling used by our company, This Improvement has greatly improved the development efficiency and user experience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] pinkfloyds commented on pull request #14954: [improvement][Resources] Improve details page return to the previous list page (#14951)
Posted by "pinkfloyds (via GitHub)" <gi...@apache.org>.
pinkfloyds commented on PR #14954:
URL: https://github.com/apache/dolphinscheduler/pull/14954#issuecomment-1730995831
@zhutong6688 Good job !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org