You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2014/10/13 10:41:30 UTC
Review Request 26638: Admin View: when Create Instance button is
disabled while the view is deploying,
the hover cursor should be "disallow" and should show tooltip text
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26638/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Srimanth Gunturi, and Yusaku Sako.
Bugs: AMBARI-7755
https://issues.apache.org/jira/browse/AMBARI-7755
Repository: ambari
Description
-------
When the view is deploying, we automatically disable "Create Instance" button, which is good.
However, the mouse cursor should change to indicate the button is not clickable, and we should show a tooltip for more information.
Cursor = not-allowed
Tooltip = "Unable to create view instances"
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 789af82
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html d2ab32a
Diff: https://reviews.apache.org/r/26638/diff/
Testing
-------
There are no unit test with this patch as the patch includes just css and html changes which cannot be unit tested.
Applied the patch and tested e2e on a live cluster with branch-1.7.0 bits
Thanks,
Jaimin Jetly
Re: Review Request 26638: Admin View: when Create Instance button is
disabled while the view is deploying,
the hover cursor should be "disallow" and should show tooltip text
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26638/#review56416
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 13, 2014, 8:41 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26638/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 8:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Srimanth Gunturi, and Yusaku Sako.
>
>
> Bugs: AMBARI-7755
> https://issues.apache.org/jira/browse/AMBARI-7755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When the view is deploying, we automatically disable "Create Instance" button, which is good.
> However, the mouse cursor should change to indicate the button is not clickable, and we should show a tooltip for more information.
> Cursor = not-allowed
> Tooltip = "Unable to create view instances"
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 789af82
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html d2ab32a
>
> Diff: https://reviews.apache.org/r/26638/diff/
>
>
> Testing
> -------
>
> There are no unit test with this patch as the patch includes just css and html changes which cannot be unit tested.
>
> Applied the patch and tested e2e on a live cluster with branch-1.7.0 bits
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 26638: Admin View: when Create Instance button is
disabled while the view is deploying,
the hover cursor should be "disallow" and should show tooltip text
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26638/#review56413
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On Oct. 13, 2014, 8:41 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26638/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 8:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Srimanth Gunturi, and Yusaku Sako.
>
>
> Bugs: AMBARI-7755
> https://issues.apache.org/jira/browse/AMBARI-7755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When the view is deploying, we automatically disable "Create Instance" button, which is good.
> However, the mouse cursor should change to indicate the button is not clickable, and we should show a tooltip for more information.
> Cursor = not-allowed
> Tooltip = "Unable to create view instances"
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 789af82
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html d2ab32a
>
> Diff: https://reviews.apache.org/r/26638/diff/
>
>
> Testing
> -------
>
> There are no unit test with this patch as the patch includes just css and html changes which cannot be unit tested.
>
> Applied the patch and tested e2e on a live cluster with branch-1.7.0 bits
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 26638: Admin View: when Create Instance button is
disabled while the view is deploying,
the hover cursor should be "disallow" and should show tooltip text
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26638/#review56415
-----------------------------------------------------------
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
<https://reviews.apache.org/r/26638/#comment96694>
I don't know if you want to fix it in this patch, but one of the class names is "createisntance" instead of "createinstance".
- Alejandro Fernandez
On Oct. 13, 2014, 8:41 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26638/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 8:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Srimanth Gunturi, and Yusaku Sako.
>
>
> Bugs: AMBARI-7755
> https://issues.apache.org/jira/browse/AMBARI-7755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When the view is deploying, we automatically disable "Create Instance" button, which is good.
> However, the mouse cursor should change to indicate the button is not clickable, and we should show a tooltip for more information.
> Cursor = not-allowed
> Tooltip = "Unable to create view instances"
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 789af82
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html d2ab32a
>
> Diff: https://reviews.apache.org/r/26638/diff/
>
>
> Testing
> -------
>
> There are no unit test with this patch as the patch includes just css and html changes which cannot be unit tested.
>
> Applied the patch and tested e2e on a live cluster with branch-1.7.0 bits
>
>
> Thanks,
>
> Jaimin Jetly
>
>