You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sis.apache.org by Martin Desruisseaux <ma...@geomatys.fr> on 2013/06/06 21:05:54 UTC
Proposal to move GeoHashUtils to org.apache.sis.index
Hello all
Following on the move of QuadTree related classes to the
"org.apache.index.tree" package, I realized that GeoHashUtils could also
be seen as a kind of index. Would it be okay to do the following?
* Move it to the "org.apache.sis.index" package.
* Move it from "sis-referencing" to "sis-storage" module, together
with QuadTree.
* Rename it as "GeoHashCoder" by analogy with the "geocoding" process [1].
* Make the methods non-static, for allowing configuration (precision,
32 vs 36 bits variants)
Other ideas are welcome if "...sis.index" seems weird for that class.
Martin
[1] http://en.wikipedia.org/wiki/Geocoding
Re: Proposal to move GeoHashUtils to org.apache.sis.index
Posted by Adam Estrada <es...@gmail.com>.
Yes! Outstanding, Martin!
Adam
On Jun 7, 2013, at 9:16 PM, Mattmann, Chris A (398J) wrote:
> #winning
>
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> Chris Mattmann, Ph.D.
> Senior Computer Scientist
> NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
> Office: 171-266B, Mailstop: 171-246
> Email: chris.a.mattmann@nasa.gov
> WWW: http://sunset.usc.edu/~mattmann/
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> Adjunct Assistant Professor, Computer Science Department
> University of Southern California, Los Angeles, CA 90089 USA
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
>
>
>
>
>
> -----Original Message-----
> From: Martin Desruisseaux <ma...@geomatys.fr>
> Organization: Geomatys
> Reply-To: "dev@sis.apache.org" <de...@sis.apache.org>
> Date: Friday, June 7, 2013 9:59 AM
> To: "dev@sis.apache.org" <de...@sis.apache.org>
> Subject: Re: Proposal to move GeoHashUtils to org.apache.sis.index
>
>> Done the following tasks:
>>
>> * Replaced (DataStore + AbstractDataStore) by a single DataStore
>> abstract class
>> * Renamed DataStoreConnection as StorageConnector
>> * Renamed GeoHashUtils as GeoHashCoder and moved to the index package
>> of sis-storage.
>> * Made GeoHashCoder method non-static. Also modified the
>> implementation in this process, and upgraded the test case from
>> JUnit 3 to JUnit 4.
>>
>>
>> Martin
>>
>
Re: Proposal to move GeoHashUtils to org.apache.sis.index
Posted by "Mattmann, Chris A (398J)" <ch...@jpl.nasa.gov>.
#winning
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.a.mattmann@nasa.gov
WWW: http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
-----Original Message-----
From: Martin Desruisseaux <ma...@geomatys.fr>
Organization: Geomatys
Reply-To: "dev@sis.apache.org" <de...@sis.apache.org>
Date: Friday, June 7, 2013 9:59 AM
To: "dev@sis.apache.org" <de...@sis.apache.org>
Subject: Re: Proposal to move GeoHashUtils to org.apache.sis.index
>Done the following tasks:
>
> * Replaced (DataStore + AbstractDataStore) by a single DataStore
> abstract class
> * Renamed DataStoreConnection as StorageConnector
> * Renamed GeoHashUtils as GeoHashCoder and moved to the index package
> of sis-storage.
> * Made GeoHashCoder method non-static. Also modified the
> implementation in this process, and upgraded the test case from
> JUnit 3 to JUnit 4.
>
>
> Martin
>
Re: Proposal to move GeoHashUtils to org.apache.sis.index
Posted by Martin Desruisseaux <ma...@geomatys.fr>.
Done the following tasks:
* Replaced (DataStore + AbstractDataStore) by a single DataStore
abstract class
* Renamed DataStoreConnection as StorageConnector
* Renamed GeoHashUtils as GeoHashCoder and moved to the index package
of sis-storage.
* Made GeoHashCoder method non-static. Also modified the
implementation in this process, and upgraded the test case from
JUnit 3 to JUnit 4.
Martin
Re: Proposal to move GeoHashUtils to org.apache.sis.index
Posted by Adam Estrada <es...@gmail.com>.
+1...
On Fri, Jun 7, 2013 at 7:32 AM, Joe White <wh...@gmail.com> wrote:
> +1 as well.
> Joe
> On Jun 6, 2013, at 11:45 PM, "Mattmann, Chris A (398J)" <
> chris.a.mattmann@jpl.nasa.gov> wrote:
>
> > +1 to all bullets below.
> >
> > Cheers,
> > Chris
> >
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > Chris Mattmann, Ph.D.
> > Senior Computer Scientist
> > NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
> > Office: 171-266B, Mailstop: 171-246
> > Email: chris.a.mattmann@nasa.gov
> > WWW: http://sunset.usc.edu/~mattmann/
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > Adjunct Assistant Professor, Computer Science Department
> > University of Southern California, Los Angeles, CA 90089 USA
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >
> >
> >
> >
> >
> >
> > -----Original Message-----
> > From: Martin Desruisseaux <ma...@geomatys.fr>
> > Organization: Geomatys
> > Reply-To: "dev@sis.apache.org" <de...@sis.apache.org>
> > Date: Thursday, June 6, 2013 12:05 PM
> > To: Apache SIS <de...@sis.apache.org>
> > Subject: Proposal to move GeoHashUtils to org.apache.sis.index
> >
> >> Hello all
> >>
> >> Following on the move of QuadTree related classes to the
> >> "org.apache.index.tree" package, I realized that GeoHashUtils could also
> >> be seen as a kind of index. Would it be okay to do the following?
> >>
> >> * Move it to the "org.apache.sis.index" package.
> >> * Move it from "sis-referencing" to "sis-storage" module, together
> >> with QuadTree.
> >> * Rename it as "GeoHashCoder" by analogy with the "geocoding" process
> >> [1].
> >> * Make the methods non-static, for allowing configuration (precision,
> >> 32 vs 36 bits variants)
> >>
> >>
> >> Other ideas are welcome if "...sis.index" seems weird for that class.
> >>
> >>
> >> Martin
> >>
> >>
> >> [1] http://en.wikipedia.org/wiki/Geocoding
> >>
> >
>
>
Re: Proposal to move GeoHashUtils to org.apache.sis.index
Posted by Joe White <wh...@gmail.com>.
+1 as well.
Joe
On Jun 6, 2013, at 11:45 PM, "Mattmann, Chris A (398J)" <ch...@jpl.nasa.gov> wrote:
> +1 to all bullets below.
>
> Cheers,
> Chris
>
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> Chris Mattmann, Ph.D.
> Senior Computer Scientist
> NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
> Office: 171-266B, Mailstop: 171-246
> Email: chris.a.mattmann@nasa.gov
> WWW: http://sunset.usc.edu/~mattmann/
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> Adjunct Assistant Professor, Computer Science Department
> University of Southern California, Los Angeles, CA 90089 USA
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
>
>
>
>
>
> -----Original Message-----
> From: Martin Desruisseaux <ma...@geomatys.fr>
> Organization: Geomatys
> Reply-To: "dev@sis.apache.org" <de...@sis.apache.org>
> Date: Thursday, June 6, 2013 12:05 PM
> To: Apache SIS <de...@sis.apache.org>
> Subject: Proposal to move GeoHashUtils to org.apache.sis.index
>
>> Hello all
>>
>> Following on the move of QuadTree related classes to the
>> "org.apache.index.tree" package, I realized that GeoHashUtils could also
>> be seen as a kind of index. Would it be okay to do the following?
>>
>> * Move it to the "org.apache.sis.index" package.
>> * Move it from "sis-referencing" to "sis-storage" module, together
>> with QuadTree.
>> * Rename it as "GeoHashCoder" by analogy with the "geocoding" process
>> [1].
>> * Make the methods non-static, for allowing configuration (precision,
>> 32 vs 36 bits variants)
>>
>>
>> Other ideas are welcome if "...sis.index" seems weird for that class.
>>
>>
>> Martin
>>
>>
>> [1] http://en.wikipedia.org/wiki/Geocoding
>>
>
Re: Proposal to move GeoHashUtils to org.apache.sis.index
Posted by "Mattmann, Chris A (398J)" <ch...@jpl.nasa.gov>.
+1 to all bullets below.
Cheers,
Chris
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.a.mattmann@nasa.gov
WWW: http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
-----Original Message-----
From: Martin Desruisseaux <ma...@geomatys.fr>
Organization: Geomatys
Reply-To: "dev@sis.apache.org" <de...@sis.apache.org>
Date: Thursday, June 6, 2013 12:05 PM
To: Apache SIS <de...@sis.apache.org>
Subject: Proposal to move GeoHashUtils to org.apache.sis.index
>Hello all
>
>Following on the move of QuadTree related classes to the
>"org.apache.index.tree" package, I realized that GeoHashUtils could also
>be seen as a kind of index. Would it be okay to do the following?
>
> * Move it to the "org.apache.sis.index" package.
> * Move it from "sis-referencing" to "sis-storage" module, together
> with QuadTree.
> * Rename it as "GeoHashCoder" by analogy with the "geocoding" process
>[1].
> * Make the methods non-static, for allowing configuration (precision,
> 32 vs 36 bits variants)
>
>
>Other ideas are welcome if "...sis.index" seems weird for that class.
>
>
> Martin
>
>
>[1] http://en.wikipedia.org/wiki/Geocoding
>