You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/22 09:05:31 UTC

[GitHub] [flink] JingsongLi commented on a change in pull request #9196: [FLINK-13351][table-blink-planner]duplicate case ROW match in FlinkTy…

JingsongLi commented on a change in pull request #9196: [FLINK-13351][table-blink-planner]duplicate case ROW match in FlinkTy…
URL: https://github.com/apache/flink/pull/9196#discussion_r305741741
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala
 ##########
 @@ -479,12 +479,6 @@ object FlinkTypeFactory {
         val genericRelDataType = relDataType.asInstanceOf[GenericRelDataType]
         genericRelDataType.genericType
 
-      case ROW if relDataType.isInstanceOf[RelRecordType] =>
-        val recordType = relDataType.asInstanceOf[RelRecordType]
-        RowType.of(
-          recordType.getFieldList.map(_.getType).map(toLogicalType).toArray,
-          recordType.getFieldNames.toSeq.toArray)
-
       case ROW if relDataType.isInstanceOf[RelRecordType] =>
         toLogicalRowType(relDataType.asInstanceOf[RelRecordType])
 
 Review comment:
   Remove cast.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services