You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "Arina Ielchiieva (JIRA)" <ji...@apache.org> on 2017/05/23 14:04:04 UTC
[jira] [Updated] (DRILL-5533) Fix flag assignment in
FunctionInitializer.checkInit() method
[ https://issues.apache.org/jira/browse/DRILL-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arina Ielchiieva updated DRILL-5533:
------------------------------------
Description:
FunctionInitializer.checkInit() method uses DCL to ensure that function body is loaded only once. But flag parameter is never updated and all threads are entering synchronized block.
Also FunctionInitializer.getImports() always returns empty list.
https://github.com/apache/drill/blob/3e8b01d5b0d3013e3811913f0fd6028b22c1ac3f/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionInitializer.java
Changes:
1. Fix DCL in FunctionInitializer.checkInit() method (update flag parameter when function body is loaded).
2. Fix ImportGrabber.getImports() method to return list with imports.
3. Add unit tests for FunctionInitializer.
4. Minor refactoring (rename methods, add javadoc).
was:
FunctionInitializer.checkInit() method uses DCL to ensure that function body is loaded only once. But flag parameter is never updated and all threads are entering synchronized block.
Also FunctionInitializer.getImports() always returns empty list.
https://github.com/apache/drill/blob/3e8b01d5b0d3013e3811913f0fd6028b22c1ac3f/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionInitializer.java
Changes:
1. Fix DCL in FunctionInitializer.checkInit() method (update flag parameter when function body is loaded).
2. Fix ImportGrabber.getImports() method to return list with imports.
3. Add unit tests for FunctionInitializer.
4, Minor refactoring (rename methods, add javadoc).
> Fix flag assignment in FunctionInitializer.checkInit() method
> -------------------------------------------------------------
>
> Key: DRILL-5533
> URL: https://issues.apache.org/jira/browse/DRILL-5533
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.10.0
> Reporter: Arina Ielchiieva
> Assignee: Arina Ielchiieva
> Priority: Minor
>
> FunctionInitializer.checkInit() method uses DCL to ensure that function body is loaded only once. But flag parameter is never updated and all threads are entering synchronized block.
> Also FunctionInitializer.getImports() always returns empty list.
> https://github.com/apache/drill/blob/3e8b01d5b0d3013e3811913f0fd6028b22c1ac3f/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionInitializer.java
> Changes:
> 1. Fix DCL in FunctionInitializer.checkInit() method (update flag parameter when function body is loaded).
> 2. Fix ImportGrabber.getImports() method to return list with imports.
> 3. Add unit tests for FunctionInitializer.
> 4. Minor refactoring (rename methods, add javadoc).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)