You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by kw...@apache.org on 2022/03/17 08:08:30 UTC
[jackrabbit-filevault-package-maven-plugin] branch master updated: JCRVLT-616 extend default value for parameter "excludes" (#73)
This is an automated email from the ASF dual-hosted git repository.
kwin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jackrabbit-filevault-package-maven-plugin.git
The following commit(s) were added to refs/heads/master by this push:
new cbc3b6f JCRVLT-616 extend default value for parameter "excludes" (#73)
cbc3b6f is described below
commit cbc3b6f1b63b4b1da5af8e46110fa832b11a35f1
Author: Konrad Windszus <kw...@apache.org>
AuthorDate: Thu Mar 17 09:08:23 2022 +0100
JCRVLT-616 extend default value for parameter "excludes" (#73)
clarify default excludes in Javadoc
---
.../mojo/AbstractSourceAndMetadataPackageMojo.java | 17 +++++++----------
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/mojo/AbstractSourceAndMetadataPackageMojo.java b/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/mojo/AbstractSourceAndMetadataPackageMojo.java
index 0b02c76..b9f6f00 100644
--- a/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/mojo/AbstractSourceAndMetadataPackageMojo.java
+++ b/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/mojo/AbstractSourceAndMetadataPackageMojo.java
@@ -50,7 +50,7 @@ public abstract class AbstractSourceAndMetadataPackageMojo extends AbstractMetad
/**
- * The file name patterns to exclude (in addition to the default ones if {@link AbstractSourceAndMetadataPackageMojo#addDefaultExcludes}. The format of each pattern is described in {@link DirectoryScanner}.
+ * The file name patterns to exclude (in addition to the default ones mentioned at {@link AbstractSourceAndMetadataPackageMojo#addDefaultExcludes}. The format of each pattern is described in {@link DirectoryScanner}.
* The comparison is against the path relative to the according filter root.
* Since this is hardly predictable it is recommended to use only filename/directory name patterns here
* but not take into account file system hierarchies!
@@ -58,20 +58,16 @@ public abstract class AbstractSourceAndMetadataPackageMojo extends AbstractMetad
* Each value is either a regex pattern if enclosed within {@code %regex[} and {@code ]}, otherwise an
* <a href="https://ant.apache.org/manual/dirtasks.html#patterns">Ant pattern</a>.
*/
- @Parameter(property = "vault.excludes", defaultValue = "**/.vlt,**/.vltignore", required = true)
+ @Parameter(property = "vault.excludes", defaultValue = "**/.vlt,**/.vltignore,**/.gitignore", required = true)
protected Set<String> excludes;
/**
- * By default files like {@code .gitignore}, {@code .cvsignore} etc. are excluded which means they will not being
- * copied. If you need them for a particular reason you can do that by settings this to {@code false}. This means
- * all files like the following will be copied.
+ * By default certain metadata files are excluded which means they will not be copied into the package.
+ * If you need them for a particular reason you can do that by setting this parameter to {@code false}. This means
+ * all files matching the following <a href="https://ant.apache.org/manual/dirtasks.html#patterns">Ant patterns</a> won't be copied by default.
* <ul>
* <li>Misc: **/*~, **/#*#, **/.#*, **/%*%, **/._*</li>
* <li>CVS: **/CVS, **/CVS/**, **/.cvsignore</li>
- * <li>RCS: **/RCS, **/RCS/**</li>
- * <li>SCCS: **/SCCS, **/SCCS/**</li>
- * <li>VSSercer: **/vssver.scc</li>
- * <li>MKS: **/project.pj</li>
* <li>SVN: **/.svn, **/.svn/**</li>
* <li>GNU: **/.arch-ids, **/.arch-ids/**</li>
* <li>Bazaar: **/.bzr, **/.bzr/**</li>
@@ -79,13 +75,14 @@ public abstract class AbstractSourceAndMetadataPackageMojo extends AbstractMetad
* <li>Mac: **/.DS_Store</li>
* <li>Serena Dimension: **/.metadata, **/.metadata/**</li>
* <li>Mercurial: **/.hg, **/.hg/**</li>
- * <li>GIT: **/.git, **/.gitignore, **/.gitattributes, **/.git/**</li>
+ * <li>GIT: **/.git, **/.git/**</li>
* <li>Bitkeeper: **/BitKeeper, **/BitKeeper/**, **/ChangeSet,
* **/ChangeSet/**</li>
* <li>Darcs: **/_darcs, **/_darcs/**, **/.darcsrepo,
* **/.darcsrepo/****/-darcs-backup*, **/.darcs-temp-mail
* </ul>
*
+ * @see {@link DirectoryScanner#DEFAULTEXCLUDES}
* @since 1.1.0
*/
@Parameter(defaultValue = "true")