[GitHub] zheng-da commented on a change in pull request #10451: [WIP] Add Foreach

[GitBox <gi...@apache.org>]

zheng-da commented on a change in pull request #10451: [WIP] Add Foreach
URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r189172779
 
 

 ##########
 File path: python/mxnet/symbol/contrib.py
 ##########
 @@ -91,3 +98,99 @@ def rand_zipfian(true_classes, num_sampled, range_max):
     expected_prob_sampled = ((sampled_cls_fp64 + 2.0) / (sampled_cls_fp64 + 1.0)).log() / log_range
     expected_count_sampled = expected_prob_sampled * num_sampled
     return sampled_classes, expected_count_true, expected_count_sampled
+
+def _get_graph_inputs(subg, name, prefix):
 
 Review comment:
   the prefix is used for pruning. this part hasn't been implemented yet. I'll probably implement it in the next PR. This PR is already very large.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services