You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2022/07/22 14:40:51 UTC

[GitHub] [knox] nanhuirong opened a new pull request, #613: KNOX-2779 - support multiple hosts for gateway.host config

nanhuirong opened a new pull request, #613:
URL: https://github.com/apache/knox/pull/613

   support multiple hosts for gateway.host config


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [knox] nanhuirong commented on pull request #613: KNOX-2779 - support multiple hosts for gateway.host config

Posted by GitBox <gi...@apache.org>.
nanhuirong commented on PR #613:
URL: https://github.com/apache/knox/pull/613#issuecomment-1201238026

   @smolnar82 , Please review the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [knox] lmccay commented on pull request #613: KNOX-2779 - support multiple hosts for gateway.host config

Posted by GitBox <gi...@apache.org>.
lmccay commented on PR #613:
URL: https://github.com/apache/knox/pull/613#issuecomment-1216991685

   @nanhuirong - sure - start by filing a JIRA and describe what documentation needs to be updated and then you can provide the documentation in the JIRA or follow the process description in https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-DocumentationContributorWorkflow
   
   Note that the site docs are in subversion, not in github.
   So, you will likely have to attach the patch file to the JIRA.
   
   Thanks for your interest and followup!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [knox] lmccay commented on pull request #613: KNOX-2779 - support multiple hosts for gateway.host config

Posted by GitBox <gi...@apache.org>.
lmccay commented on PR #613:
URL: https://github.com/apache/knox/pull/613#issuecomment-1211136654

   @nanhuirong - thank you for your pull request. I've merged this into master and it will be included in the next release.
   Let's also file a JIRA for documentation for this improvement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [knox] nanhuirong commented on pull request #613: KNOX-2779 - support multiple hosts for gateway.host config

Posted by GitBox <gi...@apache.org>.
nanhuirong commented on PR #613:
URL: https://github.com/apache/knox/pull/613#issuecomment-1193134189

   > @nanhuirong - we need to get unit tests to insure that previous behavior with only one in the list and new behavior with multiples work as expected and do not regress in the future.
   
   @lmccay -  We need two network cards for this config and can't assume another ip. Thus, I just test the gateway.host properties. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [knox] lmccay merged pull request #613: KNOX-2779 - support multiple hosts for gateway.host config

Posted by GitBox <gi...@apache.org>.
lmccay merged PR #613:
URL: https://github.com/apache/knox/pull/613


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [knox] nanhuirong commented on pull request #613: KNOX-2779 - support multiple hosts for gateway.host config

Posted by GitBox <gi...@apache.org>.
nanhuirong commented on PR #613:
URL: https://github.com/apache/knox/pull/613#issuecomment-1212857182

   > Let's also file a JIRA for documentation for this improvement.
   
   I don't know how to do for this. Do you have any suggestion?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org