You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/01 14:56:21 UTC
[jira] [Commented] (FLINK-4456) Replace ActorGateway in Task by
interface
[ https://issues.apache.org/jira/browse/FLINK-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455674#comment-15455674 ]
ASF GitHub Bot commented on FLINK-4456:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2456
[FLINK-4456] Replace ActorGateway in Task and RuntimeEnvironment
Replaces the `ActorGateway` in `Task` and `RuntimeEnvironment` by interfaces to decouple these components from the actors.
- Introduces a `TaskExecutionStateListener` interface for `TaskExecutionState` update messages
- Replaces the job manager `ActorGateway` by `InputSplitProvider` and `CheckpointNotifier`
- Replaces the task manager `ActorGateway` by `TaskManagerConnection`
The implementations using the `ActorGateways` are
- `InputSplitProvider` --> `TaskInputSplitProvider`
- `TaskExecutionStateListener` --> `ActorGatewayTaskExecutionStateListener`
- `CheckpointNotifier` --> `ActorGatewayCheckpointNotifier`
- `TaskManagerConnection` --> `ActorGatewayTaskManagerConnection`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink FLINK-4456
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2456
----
commit 578b2ef0bacc57f093150e4addd56b833ebbdf05
Author: Till Rohrmann <tr...@apache.org>
Date: 2016-09-01T12:41:44Z
[FLINK-4456] Introduce TaskExecutionStateListener for Task
commit bd85b45e61160e5d86578da1e52c60ef1bde7c10
Author: Till Rohrmann <tr...@apache.org>
Date: 2016-09-01T13:50:36Z
Replace JobManagerGateway in Task by InputSplitProvider and CheckpointNotifier
commit d665583ca03e6748187ada46ce30c39704b17fd8
Author: Till Rohrmann <tr...@apache.org>
Date: 2016-09-01T14:36:31Z
Replace the TaskManager ActorGateway by TaskManagerConnection in Task
----
> Replace ActorGateway in Task by interface
> -----------------------------------------
>
> Key: FLINK-4456
> URL: https://issues.apache.org/jira/browse/FLINK-4456
> Project: Flink
> Issue Type: Improvement
> Components: TaskManager
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> The {{Task}} communicates with the outside world ({{JobManager}} and {{TaskManager}}) via {{ActorGateways}}. This bakes in the dependency on actors.
> In terms of modularization and an improved abstraction (especially wrt Flip-6) I propose to replace the {{ActorGateways}} by interfaces which exposes the required methods. The current implementation would then simply wrap the method calls in messages and send them via the {{ActorGateway}} to the recipient.
> In Flip-6 the {{JobMaster}} could simply implement these interfaces as part of their RPC contract.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)