[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2916: [Flink-K8s-V2] Port the new module codes to Streampark-flink-kubernetes-v2

["wolfboys (via GitHub)" <gi...@apache.org>]

wolfboys commented on code in PR #2916:
URL: https://github.com/apache/incubator-streampark/pull/2916#discussion_r1283439679


##########
streampark-common/pom.xml:
##########
@@ -128,6 +128,32 @@
             <version>${streampark.shaded.version}</version>
         </dependency>
 
+        <!-- ZIO -->
+        <dependency>

Review Comment:
   "common" is a public module that many other modules depend on. It is not a good idea to add ZIO dependency in the common module. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org