[GitHub] [beam] Malarg commented on a diff in pull request #24283: Example from embedded to standalone playground sent by path

[GitBox <gi...@apache.org>]

Malarg commented on code in PR #24283:
URL: https://github.com/apache/beam/pull/24283#discussion_r1030090520


##########
playground/frontend/lib/pages/embedded_playground/components/embedded_actions.dart:
##########
@@ -58,16 +57,12 @@ class EmbeddedActions extends StatelessWidget {
   void _openStandalonePlayground(PlaygroundController controller) {
     // The empty list forces the parsing of EmptyExampleLoadingDescriptor
     // and prevents the glimpse of the default catalog example.
-    final window = html.window.open(
-      '/?$kExamplesParam=[]&$kSdkParam=${controller.sdk?.id}',
-      '',
-    );
 
-    javaScriptPostMessageRepeated(
-      window,
-      SetContentMessage(
-        descriptor: controller.getLoadingDescriptor(),
-      ),
+    var descriptors = controller.getLoadingDescriptor().toJson()['descriptors'];
+    var json = jsonEncode(descriptors);
+    html.window.open(
+      '/?$kExamplesParam=$json&$kSdkParam=${controller.sdk?.id}',
+      '',

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org