[GitHub] brodybits commented on issue #594: Deprecate BuildHelper & PermissionHelper to be removed someday in the future?

[GitBox <gi...@apache.org>]

brodybits commented on issue #594: Deprecate BuildHelper & PermissionHelper to be removed someday in the future?
URL: https://github.com/apache/cordova-android/issues/594#issuecomment-443028636
 
 
   Thanks @dpogue. I spotted a couple things in `PermissionHelper.java`:
   
   From the class description:
   > ```
   > * This class provides reflective methods for permission requesting and checking so that plugins
   > * written for cordova-android 5.0.0+ can still compile with earlier cordova-android versions.
   > ```
   
   I think there should be no more need for plugins to support running on cordova-android pre-5.0.0.
   
   The class also has a private static `deliverPermissionResult` that is not called anywhere.
   
   `BuildHelper.java` seems to just get a field from a BuildConfig class:
   
   https://github.com/apache/cordova-android/blob/8a4ae311ce165e31f0511ae43274aa52d3773fd2/framework/src/org/apache/cordova/BuildHelper.java#L54-L56
   
   and check for exceptions, which is all very basic Java programming.
   
   I would really favor marking these classes as deprecated classes, to be removed from a major release someday in the future, with plenty of advance warning.
   
   I am looking forward to the response from @macdonst.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org