You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 00:18:45 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #13521: In DagBag set read_dags_from_db from config

kaxil commented on a change in pull request #13521:
URL: https://github.com/apache/airflow/pull/13521#discussion_r553030534



##########
File path: airflow/models/dagbag.py
##########
@@ -90,7 +90,7 @@ def __init__(
         include_examples: bool = conf.getboolean('core', 'LOAD_EXAMPLES'),
         include_smart_sensor: bool = conf.getboolean('smart_sensor', 'USE_SMART_SENSOR'),
         safe_mode: bool = conf.getboolean('core', 'DAG_DISCOVERY_SAFE_MODE'),
-        read_dags_from_db: bool = False,
+        read_dags_from_db: bool = conf.getboolean('core', 'STORE_DAG_CODE'),

Review comment:
       Hey John as mentioned on Slack, this won't be the correct fix, 
   
   `read_dags_from_db` decides if it should read the DAGs from DB (Serialized Dags from serialized_dag table). The `conf.getboolean('core', 'STORE_DAG_CODE')` config is only used in Webserver to show the Code (as plain strings) from the `dag_code` table.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org