You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/09/01 10:21:50 UTC
[GitHub] [kylin] zhangayqian opened a new pull request #1387: KYLIN-4725 NSparkCubingStep returns error state when pause build job
zhangayqian opened a new pull request #1387:
URL: https://github.com/apache/kylin/pull/1387
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1387: KYLIN-4725 NSparkCubingStep returns error state when pause build job
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1387:
URL: https://github.com/apache/kylin/pull/1387#issuecomment-685245836
This pull request **introduces 1 alert** when merging 028ca4322b4c41cb5b069a0cefcd714faccbafe2 into 24fabdc69201cdb114c18a541ddf2995735a7f09 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-88fdb79bcabc785ca8995df72ca2fea4434834d0)
**new alerts:**
* 1 for Dereferenced variable may be null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1387: KYLIN-4725 NSparkCubingStep returns error state when pause build job
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1387:
URL: https://github.com/apache/kylin/pull/1387
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1387: KYLIN-4725 NSparkCubingStep returns error state when pause build job
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1387:
URL: https://github.com/apache/kylin/pull/1387#issuecomment-684783212
This pull request **introduces 1 alert** when merging 24cebd3ce8f0ded7ee1243cc5ba812ea6d64ba90 into 5eb9b37cf4164f4cf94076aa84fd47f346ae4b17 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-2ca66810b6b98bc801c2267a6adff1405821f6c5)
**new alerts:**
* 1 for Dereferenced variable may be null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on a change in pull request #1387: KYLIN-4725 NSparkCubingStep returns error state when pause build job
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on a change in pull request #1387:
URL: https://github.com/apache/kylin/pull/1387#discussion_r481175258
##########
File path: core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
##########
@@ -196,8 +196,10 @@ public final ExecuteResult execute(ExecutableContext executableContext) throws E
try {
result = doWork(executableContext);
} catch (Throwable e) {
- logger.error("error running Executable: {}", this.toString());
- catchedException = e;
+ if (!(e instanceof JobStoppedException)) {
Review comment:
Could you please change to this way:
```java
} catch (JobStoppedException e) {
// Ignore it
} catch (Throwable e) {
throw new ExecuteException(e);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1387: KYLIN-4725 NSparkCubingStep returns error state when pause build job
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1387:
URL: https://github.com/apache/kylin/pull/1387#issuecomment-685234663
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org