You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by sunsky6 <gi...@git.apache.org> on 2018/01/16 02:27:22 UTC
[GitHub] incubator-weex pull request #982: + [android] support "word-break" style in ...
GitHub user sunsky6 opened a pull request:
https://github.com/apache/incubator-weex/pull/982
+ [android] support "word-break" style in text
* Support "word-break" style in text. Can use "keep-all" or "break-all".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunsky6/incubator-weex android-feature-text-word-break
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/982.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #982
----
commit 085e6f3e4c9890012681a26f1b5e19b515bbbd5b
Author: sunsky6 <su...@...>
Date: 2018-01-15T08:09:26Z
+ [android] support "word-break" style in text
----
---
[GitHub] incubator-weex issue #982: + [android] support "word-break" style in text
Posted by gubaojian <gi...@git.apache.org>.
Github user gubaojian commented on the issue:
https://github.com/apache/incubator-weex/pull/982
great work
---
[GitHub] incubator-weex issue #982: + [android] support "word-break" style in text
Posted by sunsky6 <gi...@git.apache.org>.
Github user sunsky6 commented on the issue:
https://github.com/apache/incubator-weex/pull/982
Hey ~ @misakuo @gubaojian
This is a testcase -- [Word-Break](http://dotwe.org/vue/f5011e3908f4f4ab3b854bc5b990b880).
I found iOS doesn't support `word-break` style, but the default way is `break-all`.
I will create a new pull request later, then try to support it.
Thx you both.
---
[GitHub] incubator-weex issue #982: + [android] support "word-break" style in text
Posted by misakuo <gi...@git.apache.org>.
Github user misakuo commented on the issue:
https://github.com/apache/incubator-weex/pull/982
@acton393 Does iOS support the `word-break` style now?
---
[GitHub] incubator-weex pull request #982: + [android] support "word-break" style in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/982
---
[GitHub] incubator-weex issue #982: + [android] support "word-break" style in text
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/982
<!--
0 failure:
2 warning: No Changelog chan..., This PR should up...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex issue #982: + [android] support "word-break" style in text
Posted by sunsky6 <gi...@git.apache.org>.
Github user sunsky6 commented on the issue:
https://github.com/apache/incubator-weex/pull/982
It seem like iOS doesn't support `word-break`. I can support this later.
---
[GitHub] incubator-weex issue #982: + [android] support "word-break" style in text
Posted by gubaojian <gi...@git.apache.org>.
Github user gubaojian commented on the issue:
https://github.com/apache/incubator-weex/pull/982
please provide one or more testcase on http://dotwe.org/vue
---
[GitHub] incubator-weex issue #982: + [android] support "word-break" style in text
Posted by misakuo <gi...@git.apache.org>.
Github user misakuo commented on the issue:
https://github.com/apache/incubator-weex/pull/982
Great! very useful feature. Thanks for your contribution
---