Re: svn commit: r1604749 - in /subversion/trunk/subversion/include: svn_client.h svn_wc.h

[Branko Čibej <br...@wandisco.com>]

On 23.06.2014 13:13, rhuijben@apache.org wrote:
> Author: rhuijben
> Date: Mon Jun 23 11:13:55 2014
> New Revision: 1604749

This comment doesn't really refer to this commit, but since it's recent ...

> @@ -4160,6 +4174,7 @@ svn_client_cleanup2(const char *dir_absp
>   *
>   * @deprecated Provided for limited backwards compatibility with the 1.8 API.
>   */
> +SVN_DEPRECATED
>  svn_error_t *
>  svn_client_cleanup(const char *dir,
>                     svn_client_ctx_t *ctx,

Why "limited backwards compatibility"? What exactly is limited about it?

-- Brane

-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane@wandisco.com

RE: svn commit: r1604749 - in /subversion/trunk/subversion/include: svn_client.h svn_wc.h

[Bert Huijben <be...@qqmail.nl>]

I don’t know, this was added in r1496954 with message

[[

Allow 'svn cleanup' to remove unversioned items from the working copy.

This should address the feature request from issue #3549.

 

Add two new options to 'svn cleanup', --remove-unversioned and --no-ignore.

The former causes unversioned files and directories to be removed after

successful cleanup. The latter causes ignored items to be removed as well.

 

One remaining question is what to do with externals. Right now, 'svn cleanup'

never recurses into externals. Should it recurse into externals if the

--remove-unversioned option is given? Should we change it to always recurse

into externals by default? I'm not quite sure.

]]

 

I would say that the function still does what it used to do, so we should probably just use the default text.

(This was before moving some of the new code paths into svn_client_vacuum())

 

                Bert

 

From: Branko Čibej [mailto:brane@wandisco.com] 
Sent: maandag 23 juni 2014 16:40
To: Subversion Development
Subject: Re: svn commit: r1604749 - in /subversion/trunk/subversion/include: svn_client.h svn_wc.h

 

On 23.06.2014 13:13, rhuijben@apache.org <ma...@apache.org>  wrote:

Author: rhuijben
Date: Mon Jun 23 11:13:55 2014
New Revision: 1604749


This comment doesn't really refer to this commit, but since it's recent ...




@@ -4160,6 +4174,7 @@ svn_client_cleanup2(const char *dir_absp
  *
  * @deprecated Provided for limited backwards compatibility with the 1.8 API.
  */
+SVN_DEPRECATED
 svn_error_t *
 svn_client_cleanup(const char *dir,
                    svn_client_ctx_t *ctx,


Why "limited backwards compatibility"? What exactly is limited about it?

-- Brane

-- 
Branko Čibej | Director of Subversion 
WANdisco // Non-Stop Data 
e. brane@wandisco.com <ma...@wandisco.com>