[GitHub] [spark] vanzin commented on issue #24219: [SPARK-27258][K8S]Deal with the Service name that does not match regular expression ^[a-z]([-a-z0-9]*[a-z0-9])?)

[GitBox <gi...@apache.org>]

vanzin commented on issue #24219: [SPARK-27258][K8S]Deal with the Service name that does not match regular expression ^[a-z]([-a-z0-9]*[a-z0-9])?)
URL: https://github.com/apache/spark/pull/24219#issuecomment-476712154
 
 
   Instead of adding more ad-hoc tests, I think it's better to just check if the preferred name is valid using `com.google.common.net.InternetDomainName.isValid`. It seems to do a better job than the checks that were put in this code originally.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org