[GitHub] tillrohrmann opened a new pull request #6810: [FLINK-9788] Fix ExecutionGraph inconsistency for global failures when restarting

[GitBox <gi...@apache.org>]

tillrohrmann opened a new pull request #6810: [FLINK-9788] Fix ExecutionGraph inconsistency for global failures when restarting
URL: https://github.com/apache/flink/pull/6810
 
 
   ## What is the purpose of the change
   
   The problem was that a concurrent global failure could start a concurrent
   restart operation without terminating the previous operation. Terminating
   the previous restart operation means to cancel all current Executions and
   wait for cancellation completion. Due to the missing wait, it could happen
   that previously reset Executions are being tried to reset again. This violates
   a sanity check and would lead to a restart loop.
   
   The problem is fixed by not distinguishing between a fail which happens in
   state JobStatus.RESTARTING and in any other state. Due to this, we will always
   cancel all existing Executions and only trigger the restart after all Executions
   have reached a terminal state.
   
   ## Brief change log
   
   - Remove `RESTARTING` branch from `ExecutionGraph#failGlobal`
   - Use `expectedGlobalVersion` when resetting `Executions` in `ExecutionGraph#restart`
   
   ## Verifying this change
   
   - Added `ExecutionGraphRestartTest#testConcurrentFailureWhileRestarting`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes**)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services