You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/17 06:56:57 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35544: [SPARK-38232][SQL] Explain formatted does not collect subqueries under query stage in AQE

dongjoon-hyun commented on a change in pull request #35544:
URL: https://github.com/apache/spark/pull/35544#discussion_r808725320



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
##########
@@ -723,6 +723,19 @@ class ExplainSuiteAE extends ExplainSuiteHelper with EnableAdaptiveExecutionSuit
       assert(inMemoryRelationNodeId != columnarToRowNodeId)
     }
   }
+
+  test("SPARK-38232: Explain formatted does not collect subqueries under query stage in AQE") {

Review comment:
       Thank you for adding this at `ExplainSuiteAE`. Do we have a similar test coverage in `ExplainSuite` or somewhere-else already, @ulysses-you ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org