[GitHub] [groovy] sonatype-lift[bot] commented on a change in pull request #1661: GROOVY-10278, GROOVY-10281: refactor `CompilerConfiguration` somewhat

[GitBox <gi...@apache.org>]

sonatype-lift[bot] commented on a change in pull request #1661:
URL: https://github.com/apache/groovy/pull/1661#discussion_r763492780



##########
File path: src/main/java/org/codehaus/groovy/classgen/asm/WriterController.java
##########
@@ -133,11 +132,10 @@ public void init(final AsmClassGenerator asmClassGenerator, final GeneratorConte
         this.typeChooser = new StatementMetaTypeChooser();
     }
 
-    private static ClassVisitor createClassVisitor(final ClassVisitor cv, final CompilerConfiguration config) {
-        if (!config.isLogClassgen() || cv instanceof LoggableClassVisitor) {
-            return cv;
-        }
-        return new LoggableClassVisitor(cv, config);
+    private static ClassVisitor createClassVisitor(final ClassVisitor visitor, final CompilerConfiguration config) {

Review comment:
       *UnusedVariable:*  The parameter 'config' is never read. [(details)](https://errorprone.info/bugpattern/UnusedVariable)
   (at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org