You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/27 10:26:39 UTC
[GitHub] [incubator-kyuubi] 875082356 opened a new pull request #1303: [KYUUBI #1293] Set the sub.domain default value
875082356 opened a new pull request #1303:
URL: https://github.com/apache/incubator-kyuubi/pull/1303
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1303: [KYUUBI #1293] Set the sub.domain default value
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1303:
URL: https://github.com/apache/incubator-kyuubi/pull/1303#discussion_r737334271
##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -586,7 +586,7 @@ object KyuubiConf {
.transform(_.toLowerCase(Locale.ROOT))
.checkValue(validEngineSubDomain.matcher(_).matches(),
"must be [1, 10] length alphabet string, e.g. 'abc', 'apache'")
- .createOptional
+ .createWithDefaultString("default")
Review comment:
nit: we use createWithDefault
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1303: [KYUUBI #1293] Set the sub.domain default value
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1303:
URL: https://github.com/apache/incubator-kyuubi/pull/1303#issuecomment-952782724
We may have some ut failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1303: [KYUUBI #1293] Set the sub.domain default value
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1303:
URL: https://github.com/apache/incubator-kyuubi/pull/1303#issuecomment-955196648
migration guide sounds a good thing for Kyuubi. @875082356 can you fix the failed test first ? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1303: [KYUUBI #1293] Set the sub.domain default value
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1303:
URL: https://github.com/apache/incubator-kyuubi/pull/1303#issuecomment-952809129
> After this change, we have the different default behavior of the configuration `engine.share.level.sub.domain` between version 1.3.x and version 1.4.0.
Yes, but the zk path is not designed to expose to users, I think the behavior change is safe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #1303: [KYUUBI #1293] Set the sub.domain default value
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #1303:
URL: https://github.com/apache/incubator-kyuubi/pull/1303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on pull request #1303: [KYUUBI #1293] Set the sub.domain default value
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on pull request #1303:
URL: https://github.com/apache/incubator-kyuubi/pull/1303#issuecomment-952814466
As we support the engine pool in version 1.4.0, and it's influenced by the default value. I think maybe we need a migration guide?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on pull request #1303: [KYUUBI #1293] Set the sub.domain default value
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on pull request #1303:
URL: https://github.com/apache/incubator-kyuubi/pull/1303#issuecomment-952803027
After this change, we have the different default behavior of the configuration `engine.share.level.sub.domain` between version 1.3.x and version 1.4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1303: [KYUUBI #1293] Set the sub.domain default value
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1303:
URL: https://github.com/apache/incubator-kyuubi/pull/1303#issuecomment-952812364
@875082356 can you switch the target branch to master? we can backport to 1.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1303: [KYUUBI #1293] Set the sub.domain default value
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1303:
URL: https://github.com/apache/incubator-kyuubi/pull/1303#issuecomment-952813928
> After this change, we have the different default behavior of the configuration `engine.share.level.sub.domain` between version 1.3.x and version 1.4.0.
Maybe we shall add a migration guide for inevitable breaking changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1303: [KYUUBI #1293] Set the sub.domain default value
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1303:
URL: https://github.com/apache/incubator-kyuubi/pull/1303#issuecomment-971309958
Move to #1402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org