You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ueshin (via GitHub)" <gi...@apache.org> on 2023/02/28 23:31:17 UTC
[GitHub] [spark] ueshin opened a new pull request, #40226: [SPARK-41868][CONNECT][PYTHON] Fix createDataFrame to support durations
ueshin opened a new pull request, #40226:
URL: https://github.com/apache/spark/pull/40226
### What changes were proposed in this pull request?
Fixes `createDataFrame` to support durations.
### Why are the changes needed?
Currently the following command:
```py
spark.createDataFrame(pd.DataFrame({"a": [timedelta(microseconds=123)]}))
```
raises an error:
```
[UNSUPPORTED_ARROWTYPE] Unsupported arrow type Duration(NANOSECOND).
```
because Arrow take a different type for `timedelta` objects from what Spark expects.
### Does this PR introduce _any_ user-facing change?
`timedelta` objects will be properly converted to `DayTimeIntervalType`.
### How was this patch tested?
Enabled the related test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #40226: [SPARK-41868][CONNECT][PYTHON] Fix createDataFrame to support durations
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #40226: [SPARK-41868][CONNECT][PYTHON] Fix createDataFrame to support durations
URL: https://github.com/apache/spark/pull/40226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40226: [SPARK-41868][CONNECT][PYTHON] Fix createDataFrame to support durations
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40226:
URL: https://github.com/apache/spark/pull/40226#issuecomment-1449190050
thanks, merged to master/3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org