Re: [PR] Added support for parsing nested object in query for Snowflake [datafusion-sqlparser-rs]

["kfirSatori (via GitHub)" <gi...@apache.org>]

kfirSatori commented on code in PR #2359:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2359#discussion_r3758061952


##########
src/parser/mod.rs:
##########
@@ -13036,6 +13036,31 @@ impl<'a> Parser<'a> {
                     let fields = self.parse_union_type_def()?;
                     Ok(DataType::Union(fields))
                 }
+                Keyword::OBJECT if dialect_is!(dialect is SnowflakeDialect | GenericDialect) => {

Review Comment:
   Hi @iffyio, i dont understand what do you mean.
   i did it the same way done as UNION and NULLABLE



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org