You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2020/05/31 18:51:00 UTC
[GitHub] [incubator-heron] Code0x58 opened a new pull request #3534: Fix helm chart
Code0x58 opened a new pull request #3534:
URL: https://github.com/apache/incubator-heron/pull/3534
the template string in the values.yaml wasn't rendered, so this patch renders the default value in the template
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] joshfischer1108 commented on pull request #3534: Fix helm chart
Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on pull request #3534:
URL: https://github.com/apache/incubator-heron/pull/3534#issuecomment-637427393
> 🤦 I just noticed this should have contained `{{ .Values.heron.url | default $defaultUrl }}` otherwise it will disregard an explicit value
Not a big deal. Do you want to open another PR to address it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] Code0x58 commented on pull request #3534: Fix helm chart
Posted by GitBox <gi...@apache.org>.
Code0x58 commented on pull request #3534:
URL: https://github.com/apache/incubator-heron/pull/3534#issuecomment-637227027
:facepalm: I just noticed this should have contained `{{ .Values.heron.url | default $defaultUrl }}` otherwise it will disregard an explicit value
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] nicknezis merged pull request #3534: Fix helm chart
Posted by GitBox <gi...@apache.org>.
nicknezis merged pull request #3534:
URL: https://github.com/apache/incubator-heron/pull/3534
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] joshfischer1108 commented on pull request #3534: Fix helm chart
Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on pull request #3534:
URL: https://github.com/apache/incubator-heron/pull/3534#issuecomment-637216785
@nicknezis could you review this please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] joshfischer1108 commented on pull request #3534: Fix helm chart
Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on pull request #3534:
URL: https://github.com/apache/incubator-heron/pull/3534#issuecomment-637191632
This looks good to me.. I'll let it sit for a day to make sure no one else has any concerns.
Thank you @Code0x58
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] nicknezis commented on pull request #3534: Fix helm chart
Posted by GitBox <gi...@apache.org>.
nicknezis commented on pull request #3534:
URL: https://github.com/apache/incubator-heron/pull/3534#issuecomment-637220522
Cool, I came up with a different solution using the `tpl` function as shown here. https://helm.sh/docs/howto/charts_tips_and_tricks/#using-the-tpl-function
But I think I prefer this solution better. If it worked for your local testing, I'm good with this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org