[jira] [Commented] (HIVE-5663) Refactor ORC RecordReader to operate on direct & wrapped ByteBuffers

["Brock Noland (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806457#comment-13806457 ] 

Brock Noland commented on HIVE-5663:
------------------------------------

Minor nit:

Lines like this:
{noformat}
private ByteBuffer compressed = null;
{noformat}

should be:
{noformat}
private ByteBuffer compressed;
{noformat}

since uninitialized variables are automatically set to null.

> Refactor ORC RecordReader to operate on direct & wrapped ByteBuffers
> --------------------------------------------------------------------
>
>                 Key: HIVE-5663
>                 URL: https://issues.apache.org/jira/browse/HIVE-5663
>             Project: Hive
>          Issue Type: Improvement
>          Components: File Formats
>    Affects Versions: 0.13.0
>         Environment: Ubuntu LXC 
>            Reporter: Gopal V
>            Assignee: Gopal V
>              Labels: ORC
>         Attachments: HIVE-5663.01.patch
>
>
> The current ORC RecordReader implementation assumes array structures backing the ByteBuffers it passes around between RecordReaderImpl and Compressed/Uncompressed InStream objects.
> This patch attempts to refactor those assumptions out of both classes, allowing the future use of direct byte buffers within ORC (as might come from HDFS zero-copy readers).



--
This message was sent by Atlassian JIRA
(v6.1#6144)