[jira] [Commented] (OAK-5878) SplitDocumentCleanup iterates twice over splitDocGarbage

["Julian Reschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-5878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207151#comment-16207151 ] 

Julian Reschke commented on OAK-5878:
-------------------------------------

trunk: [r1785838|http://svn.apache.org/r1785838]
1.6: [r1785844|http://svn.apache.org/r1785844]
1.4: [r1812369|http://svn.apache.org/r1812369]


> SplitDocumentCleanup iterates twice over splitDocGarbage
> --------------------------------------------------------
>
>                 Key: OAK-5878
>                 URL: https://issues.apache.org/jira/browse/OAK-5878
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: documentmk
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>              Labels: candidate_oak_1_0, candidate_oak_1_2
>             Fix For: 1.7.0, 1.8, 1.6.2, 1.4.19
>
>         Attachments: OAK-5878-2.diff, OAK-5878.diff
>
>
> {{SplitDocumentCleanup}} currently iterates twice over {{splitDocGarbage}}.
> NOTE: not the case for Mongo DB, as {{MongoVersionGCSupport}} overwrites {{deleteSplitDocuments()}}.
> {{deleteSplitDocuments()}} currently iterates over {{splitDocGarbage}} to obtain the IDs of the documents to be deleted. Instead, we could just collect the IDs inside {{disconnect()}}, the memory requirements would be the same.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)