You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhztheplayer (via GitHub)" <gi...@apache.org> on 2025/01/07 06:19:12 UTC

[PR] [VL] Gluten-it: New option `--collect-sql-metrics=execution-time` to collect slowest plan nodes into benchmark report [incubator-gluten]

zhztheplayer opened a new pull request, #8445:
URL: https://github.com/apache/incubator-gluten/pull/8445

   The option is only available with subcommand `gluten-it queries` at the moment.
   
   For example, run:
   ```
   <gluten-it> queries --local --data-gen=once --enable-history --collect-sql-metrics=execution-time
   ```
   
   The test report will include:
   ```
   Top 10 plan nodes that took longest time to execute: 
   
   |  Query  | Node ID |                       Node Name                        |         Execution Time (ms)         |
   |---------|---------|--------------------------------------------------------|-------------------------------------|
   |   q1.sql|      574|                                  ProjectExecTransformer|          [time of project] 764101004|
   |  q10.sql|    11662|                                  ProjectExecTransformer|          [time of project] 244624523|
   |  q21.sql|    20679|                        BroadcastHashJoinExecTransformer|       [time of hash probe] 229328752|
   |   q9.sql|    10762|                                  ProjectExecTransformer|          [time of project] 207020710|
   |  q18.sql|    17034|                     RegularHashAggregateExecTransformer|  [time of rowConstruction] 203232519|
   |  q21.sql|    20682|                        BroadcastHashJoinExecTransformer|       [time of hash probe] 194751117|
   |   q7.sql|     7058|                                  ProjectExecTransformer|          [time of project] 191742246|
   |  q12.sql|    13258|                                  ProjectExecTransformer|          [time of project] 149007987|
   |  q19.sql|    17803|      ScanTransformer parquet spark_catalog.default.part|    [remaining filter time] 133398000|
   |  q17.sql|    15881|  ScanTransformer parquet spark_catalog.default.lineitem|    [remaining filter time] 130078000|
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: New option `--collect-sql-metrics=execution-time` to collect slowest plan nodes into benchmark report [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8445:
URL: https://github.com/apache/incubator-gluten/pull/8445#issuecomment-2574476812

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: New option `--collect-sql-metrics=execution-time` to collect slowest plan nodes into benchmark report [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8445:
URL: https://github.com/apache/incubator-gluten/pull/8445#issuecomment-2574474598

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: New option `--collect-sql-metrics=execution-time` to collect slowest plan nodes into benchmark report [incubator-gluten]

Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer merged PR #8445:
URL: https://github.com/apache/incubator-gluten/pull/8445


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: New option `--collect-sql-metrics=execution-time` to collect slowest plan nodes into benchmark report [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8445:
URL: https://github.com/apache/incubator-gluten/pull/8445#issuecomment-2574474389

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICEGJ-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on Github Issues?
   
   https://github.com/apache/incubator-gluten/issues
   
   Then could you also rename ***commit message*** and ***pull request title*** in the following format?
   
       [GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: New option `--collect-sql-metrics=execution-time` to collect slowest plan nodes into benchmark report [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8445:
URL: https://github.com/apache/incubator-gluten/pull/8445#issuecomment-2574478265

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: New option `--collect-sql-metrics=execution-time` to collect slowest plan nodes into benchmark report [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8445:
URL: https://github.com/apache/incubator-gluten/pull/8445#issuecomment-2574541435

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: New option `--collect-sql-metrics=execution-time` to collect slowest plan nodes into benchmark report [incubator-gluten]

Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #8445:
URL: https://github.com/apache/incubator-gluten/pull/8445#discussion_r1905018602


##########
tools/gluten-it/common/src/main/scala/org/apache/gluten/integration/action/Queries.scala:
##########
@@ -141,17 +153,18 @@ object Queries {
   }
 
   private def runQuery(
-      runner: QueryRunner,
-      creator: TableCreator,
-      session: SparkSession,
-      id: String,
-      desc: String,
-      explain: Boolean,
-      randomKillTasks: Boolean): TestResultLine = {
+                        runner: QueryRunner,
+                        creator: TableCreator,
+                        session: SparkSession,
+                        id: String,
+                        desc: String,
+                        explain: Boolean,
+                        metricMapper: MetricMapper,
+                        randomKillTasks: Boolean): TestResultLine = {

Review Comment:
   Seems this is not a consistent code style. And I note there are some other alignment changes that may be made by IDE. Can we enable spotless plugin in gluten-it module?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: New option `--collect-sql-metrics=execution-time` to collect slowest plan nodes into benchmark report [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8445:
URL: https://github.com/apache/incubator-gluten/pull/8445#issuecomment-2574481196

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: New option `--collect-sql-metrics=execution-time` to collect slowest plan nodes into benchmark report [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8445:
URL: https://github.com/apache/incubator-gluten/pull/8445#issuecomment-2574539555

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: New option `--collect-sql-metrics=execution-time` to collect slowest plan nodes into benchmark report [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8445:
URL: https://github.com/apache/incubator-gluten/pull/8445#issuecomment-2574547638

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: New option `--collect-sql-metrics=execution-time` to collect slowest plan nodes into benchmark report [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8445:
URL: https://github.com/apache/incubator-gluten/pull/8445#issuecomment-2574584721

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: New option `--collect-sql-metrics=execution-time` to collect slowest plan nodes into benchmark report [incubator-gluten]

Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #8445:
URL: https://github.com/apache/incubator-gluten/pull/8445#discussion_r1905023341


##########
tools/gluten-it/common/src/main/scala/org/apache/gluten/integration/action/Queries.scala:
##########
@@ -141,17 +153,18 @@ object Queries {
   }
 
   private def runQuery(
-      runner: QueryRunner,
-      creator: TableCreator,
-      session: SparkSession,
-      id: String,
-      desc: String,
-      explain: Boolean,
-      randomKillTasks: Boolean): TestResultLine = {
+                        runner: QueryRunner,
+                        creator: TableCreator,
+                        session: SparkSession,
+                        id: String,
+                        desc: String,
+                        explain: Boolean,
+                        metricMapper: MetricMapper,
+                        randomKillTasks: Boolean): TestResultLine = {

Review Comment:
   Thank you for catching! `gluten-it` is not subject to the main repo's linter configurations, which definitely needs to improve. I'll update this PR and enable code style checks in a future PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Gluten-it: New option `--collect-sql-metrics=execution-time` to collect slowest plan nodes into benchmark report [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8445:
URL: https://github.com/apache/incubator-gluten/pull/8445#issuecomment-2574494365

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org