You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by lq...@apache.org on 2015/10/16 12:09:33 UTC
svn commit: r1708945 -
/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnection.java
Author: lquack
Date: Fri Oct 16 10:09:33 2015
New Revision: 1708945
URL: http://svn.apache.org/viewvc?rev=1708945&view=rev
Log:
QPID-6784: [Java Broker] Make _unexpectedByteBufferSizeReported volatile to avoid publication issue.
Addresses review comments from Keith Wall.
Modified:
qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnection.java
Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnection.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnection.java?rev=1708945&r1=1708944&r2=1708945&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnection.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnection.java Fri Oct 16 10:09:33 2015
@@ -66,7 +66,7 @@ public class NonBlockingConnection imple
private final AmqpPort _port;
private final AtomicBoolean _scheduled = new AtomicBoolean();
- private boolean _unexpectedByteBufferSizeUsed;
+ private volatile boolean _unexpectedByteBufferSizeReported;
public NonBlockingConnection(SocketChannel socketChannel,
ProtocolEngine protocolEngine,
@@ -486,11 +486,11 @@ public class NonBlockingConnection imple
void reportUnexpectedByteBufferSizeUsage()
{
- if (!_unexpectedByteBufferSizeUsed)
+ if (!_unexpectedByteBufferSizeReported)
{
LOGGER.info("At least one frame unexpectedly does not fit into default byte buffer size ({}B) on a connection {}.",
_port.getNetworkBufferSize(), this.toString());
- _unexpectedByteBufferSizeUsed = true;
+ _unexpectedByteBufferSizeReported = true;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org