You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/01/17 20:26:01 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #632: Add
impsort-maven-plugin
ppalaga opened a new pull request #632: Add impsort-maven-plugin
URL: https://github.com/apache/camel-quarkus/pull/632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd merged pull request #632: Add
impsort-maven-plugin
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #632: Add impsort-maven-plugin
URL: https://github.com/apache/camel-quarkus/pull/632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#632: Add impsort-maven-plugin
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #632: Add impsort-maven-plugin
URL: https://github.com/apache/camel-quarkus/pull/632#discussion_r368135083
##########
File path: poms/build-parent/pom.xml
##########
@@ -111,6 +112,17 @@
<configFile>${camel.quarkus.project.root}/tooling/eclipse-formatter-config.xml</configFile>
</configuration>
</plugin>
+ <plugin>
+ <groupId>net.revelc.code</groupId>
+ <artifactId>impsort-maven-plugin</artifactId>
+ <version>${impsort-maven-plugin.version}</version>
+ <configuration>
+ <groups>java.,javax.</groups>
Review comment:
maybe match: https://github.com/apache/camel/blob/master/buildingtools/src/main/resources/camel-checkstyle.xml#L142
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #632:
Add impsort-maven-plugin
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #632: Add impsort-maven-plugin
URL: https://github.com/apache/camel-quarkus/pull/632#discussion_r368142471
##########
File path: poms/build-parent/pom.xml
##########
@@ -111,6 +112,17 @@
<configFile>${camel.quarkus.project.root}/tooling/eclipse-formatter-config.xml</configFile>
</configuration>
</plugin>
+ <plugin>
+ <groupId>net.revelc.code</groupId>
+ <artifactId>impsort-maven-plugin</artifactId>
+ <version>${impsort-maven-plugin.version}</version>
+ <configuration>
+ <groups>java.,javax.</groups>
Review comment:
Pulling `org.w3c` and `org.xml` up sounds a bit strange, but as you wish.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services