You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Robert Kanter (JIRA)" <ji...@apache.org> on 2012/09/20 18:39:08 UTC

[jira] [Updated] (OOZIE-998) test-patch doesn't allow lines that are exactly 132 characters

     [ https://issues.apache.org/jira/browse/OOZIE-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Kanter updated OOZIE-998:
--------------------------------

    Attachment: OOZIE-998.patch
    
> test-patch doesn't allow lines that are exactly 132 characters
> --------------------------------------------------------------
>
>                 Key: OOZIE-998
>                 URL: https://issues.apache.org/jira/browse/OOZIE-998
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>            Priority: Trivial
>         Attachments: OOZIE-998.patch
>
>
> The test-patch does the following to check for lines longer than 132 characters:
> {code}longLines=`grep "^+ " ${PATCHFILE} | awk 'BEGIN{count=0}{if ( length > 132 ) { count=count+1} }END{ print count}'`{code}
> However, each line is actually one character longer than it would be once applied because of the {{+}} sign, so test-patch currently won't allow lines that are exactly 132 characters.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira