You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by co...@apache.org on 2016/02/01 12:46:03 UTC
cxf git commit: Fix signing issue
Repository: cxf
Updated Branches:
refs/heads/master 3cabac07f -> 3e843f03b
Fix signing issue
Project: http://git-wip-us.apache.org/repos/asf/cxf/repo
Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/3e843f03
Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/3e843f03
Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/3e843f03
Branch: refs/heads/master
Commit: 3e843f03b9b384f53ec7b798f87f571cd41d490f
Parents: 3cabac0
Author: Colm O hEigeartaigh <co...@apache.org>
Authored: Mon Feb 1 11:45:51 2016 +0000
Committer: Colm O hEigeartaigh <co...@apache.org>
Committed: Mon Feb 1 11:45:51 2016 +0000
----------------------------------------------------------------------
.../apache/cxf/rs/security/saml/sso/SAMLSSOResponseValidator.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cxf/blob/3e843f03/rt/rs/security/sso/saml/src/main/java/org/apache/cxf/rs/security/saml/sso/SAMLSSOResponseValidator.java
----------------------------------------------------------------------
diff --git a/rt/rs/security/sso/saml/src/main/java/org/apache/cxf/rs/security/saml/sso/SAMLSSOResponseValidator.java b/rt/rs/security/sso/saml/src/main/java/org/apache/cxf/rs/security/saml/sso/SAMLSSOResponseValidator.java
index e072817..c95e773 100644
--- a/rt/rs/security/sso/saml/src/main/java/org/apache/cxf/rs/security/saml/sso/SAMLSSOResponseValidator.java
+++ b/rt/rs/security/sso/saml/src/main/java/org/apache/cxf/rs/security/saml/sso/SAMLSSOResponseValidator.java
@@ -109,7 +109,7 @@ public class SAMLSSOResponseValidator {
}
validateIssuer(assertion.getIssuer());
- if (!enforceResponseSigned && enforceAssertionsSigned && assertion.getSignature() == null) {
+ if (!samlResponse.isSigned() && enforceAssertionsSigned && assertion.getSignature() == null) {
LOG.fine("The enclosed assertions in the SAML Response must be signed");
throw new WSSecurityException(WSSecurityException.ErrorCode.FAILURE, "invalidSAMLsecurity");
}