[GitHub] [skywalking] yswdqz commented on pull request #11354: [Feature] Substitute classes to prepare for native-image.

["yswdqz (via GitHub)" <gi...@apache.org>]

yswdqz commented on PR #11354:
URL: https://github.com/apache/skywalking/pull/11354#issuecomment-1732839364

   > It depends on whether the changes are needed at build time or runtime, i.e., @yswdqz without these changes in this PR, do we have errors at build time or runtime? If it's runtime errors, we can replace all the `*Provider` with a GraalVM-specific implementation without needing to use `unpack` and rewrite, for example, regarding the `EnvoyMetricReceiverProvider`, we can simply create an implementation `EnvoyMetricReceiverGraalProvider` that extends `EnvoyMetricReceiverProvider`, and change the name to `default-graalvm`, then modify `application.yaml`
   > 
   > ```yaml
   > envoy-metric:
   >   selector: ${SW_ENVOY_METRIC:default-graalvm}
   > ```
   > 
   > Although @wu-sheng had mentioned in elsewhere, I'd want to emphasize that, bear in mind if we want to make the native binaries first-class support, we can refactor the existing codes in many aspects to suit the native builds, as long as they are reasonable, instead of hacking the codes as if they are from third-party.
   
   The error will occur at runtime. I will try to add a new provider and test it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org