You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/14 12:58:16 UTC
[GitHub] ufoym commented on a change in pull request #12792: Fix broken
amalgamation
ufoym commented on a change in pull request #12792: Fix broken amalgamation
URL: https://github.com/apache/incubator-mxnet/pull/12792#discussion_r224991876
##########
File path: amalgamation/amalgamation.py
##########
@@ -143,7 +143,12 @@ def expand(x, pending, stage):
continue
path = m.groups()[0]
h = path.strip('./') if "../3rdparty/" not in path else path
- source = find_source(h, x, stage)
+ if h.endswith('complex.h') and x.endswith('openblas_config.h'):
+ source = ''
+ elif h.startswith('ps/'):
Review comment:
"ps/" come from
https://github.com/apache/incubator-mxnet/blob/4649bfa641ad4129b3e83ea0af14b489e512f8f4/src/kvstore/kvstore_dist.h#L33
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services