You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2015/09/22 11:57:53 UTC
Review Request 38619: Added missing header guards for
master/validation.hpp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38619/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Repository: mesos
Description
-------
Header guards were missing in master/validation.hpp
Diffs
-----
src/master/validation.hpp 3434868
Diff: https://reviews.apache.org/r/38619/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 38619: Added missing header guards for
master/validation.hpp
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38619/#review100651
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 22, 2015, 9:57 a.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38619/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 9:57 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Header guards were missing in master/validation.hpp
>
>
> Diffs
> -----
>
> src/master/validation.hpp 3434868
>
> Diff: https://reviews.apache.org/r/38619/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 38619: Added missing header guards for
master/validation.hpp
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38619/#review99975
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38619]
All tests passed.
- Mesos ReviewBot
On Sept. 22, 2015, 9:57 a.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38619/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 9:57 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Header guards were missing in master/validation.hpp
>
>
> Diffs
> -----
>
> src/master/validation.hpp 3434868
>
> Diff: https://reviews.apache.org/r/38619/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 38619: Added missing header guards for
master/validation.hpp
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38619/#review99999
-----------------------------------------------------------
Ship it!
Ship It!
- Anand Mazumdar
On Sept. 22, 2015, 9:57 a.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38619/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 9:57 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Header guards were missing in master/validation.hpp
>
>
> Diffs
> -----
>
> src/master/validation.hpp 3434868
>
> Diff: https://reviews.apache.org/r/38619/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 38619: Added missing header guards for
master/validation.hpp
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38619/#review99972
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 九月 22, 2015, 9:57 a.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38619/
> -----------------------------------------------------------
>
> (Updated 九月 22, 2015, 9:57 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Header guards were missing in master/validation.hpp
>
>
> Diffs
> -----
>
> src/master/validation.hpp 3434868
>
> Diff: https://reviews.apache.org/r/38619/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>