Re: [PR] nimble/audio/bass: Modify add source operation in BASS [mynewt-nimble]

["rymanluk (via GitHub)" <gi...@apache.org>]

rymanluk commented on code in PR #1843:
URL: https://github.com/apache/mynewt-nimble/pull/1843#discussion_r1740618509


##########
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c:
##########
@@ -385,9 +432,11 @@ ble_svc_audio_bass_add_source(uint8_t *data, uint16_t data_len, uint16_t conn_ha
 
     ev.bass_operation_status.source_id = rcv_state->source_id;
     rcv_state->state.source_addr.type = operation.add_source.adv_addr.type;
-    memcpy(&rcv_state->state.source_addr.type, operation.add_source.adv_addr.val, 6);
+    memcpy(&rcv_state->state.source_addr.val, operation.add_source.adv_addr.val, 6);
     rcv_state->state.source_adv_sid = operation.add_source.adv_sid;
     rcv_state->state.broadcast_id = operation.add_source.broadcast_id;
+    rcv_state->state.pa_sync_state = operation.add_source.pa_sync;

Review Comment:
   maybe delegator should set it ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org