You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Dawid Wysakowicz (Jira)" <ji...@apache.org> on 2020/09/30 10:58:00 UTC
[jira] [Comment Edited] (FLINK-19440) Performance regression on
15.09.2020
[ https://issues.apache.org/jira/browse/FLINK-19440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17204639#comment-17204639 ]
Dawid Wysakowicz edited comment on FLINK-19440 at 9/30/20, 10:57 AM:
---------------------------------------------------------------------
I can confirm that upgrading Avro to version 1.10 causes performance regression. I run the benchmarks locally with avro 1.10 and also with downgraded avro version (1.8.2) and I can see similar differences in performance. Downgrading avro should be as simple as declaring a different avro version in the project pom (that's how I run the benchmarks)
The upgrade of default avro version was requested multiple times and also is needed to fix some of security vulnerabilities (as was mentioned in the ticket for upgrading Avro). There are no switches or such, that could improve the performance. It's just that Avro introduced additional logic which fixes a couple of features (e.g. logical types) on the hot path which simply slows down the performance. Therefore I think we just have to leave with the regression.
The only thing I think we can do is mention the performance regression and possible downgrading in the release notes. WDYT [~pnowojski] [~AHeise]?
was (Author: dawidwys):
I can confirm that upgrading Avro to version 1.10 causes performance regression. I run the benchmarks locally with avro 1.10 and also with downgraded avro version (1.8.2) and I can see similar differences in performance. Downgrading avro should be as simple as declaring a different avro version.
The upgrade of default avro version was requested multiple times and also is needed to fix some of security vulnerabilities (as was mentioned in the ticket for upgrading Avro). There are no switches or such, that could improve the performance. It's just that Avro introduced additional logic which fixes a couple of features (e.g. logical types) on the hot path which simply slows down the performance. Therefore I think we just have to leave with the regression.
The only thing I think we can do is mention the performance regression and possible downgrading in the release notes. WDYT [~pnowojski] [~AHeise]?
> Performance regression on 15.09.2020
> ------------------------------------
>
> Key: FLINK-19440
> URL: https://issues.apache.org/jira/browse/FLINK-19440
> Project: Flink
> Issue Type: Bug
> Components: API / Type Serialization System, Benchmarks
> Affects Versions: 1.12.0
> Reporter: Piotr Nowojski
> Assignee: Dawid Wysakowicz
> Priority: Blocker
>
> {{serializerAvro}} benchmark is showing a regression on 15.09.2020:
> http://codespeed.dak8s.net:8000/timeline/?ben=serializerAvro&env=2
--
This message was sent by Atlassian Jira
(v8.3.4#803005)