You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "schnappi17 (via GitHub)" <gi...@apache.org> on 2023/11/04 07:30:03 UTC
[PR] [Flink] Register scan metrics to flink metric groups [incubator-paimon]
schnappi17 opened a new pull request, #2260:
URL: https://github.com/apache/incubator-paimon/pull/2260
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: subtask of #2240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Flink] Register scan metrics to flink metric groups [incubator-paimon]
Posted by "tsreaper (via GitHub)" <gi...@apache.org>.
tsreaper commented on code in PR #2260:
URL: https://github.com/apache/incubator-paimon/pull/2260#discussion_r1384466338
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/metrics/FlinkMetricGroup.java:
##########
@@ -48,7 +48,6 @@ public FlinkMetricGroup(
wrapped = wrapped.addGroup(entry.getKey(), entry.getValue());
}
wrapped = wrapped.addGroup(groupName);
-
Review Comment:
Remove useless change.
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/source/ContinuousFileStoreSource.java:
##########
@@ -73,6 +75,13 @@ public SplitEnumerator<FileStoreSourceSplit, PendingSplitsCheckpoint> restoreEnu
splits = checkpoint.splits();
}
StreamTableScan scan = readBuilder.newStreamScan();
+ if (context.metricGroup() != null) {
+ try {
+ ((InnerStreamTableScan) scan)
+ .withMetricsRegistry(new FlinkMetricRegistry(context.metricGroup()));
+ } catch (UnsupportedOperationException ignore) {
Review Comment:
No need to catch `UnsupportedOperationException`. If such exception is thrown, we should implement the method, not ignore it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Flink] Register scan metrics to flink metric groups [incubator-paimon]
Posted by "tsreaper (via GitHub)" <gi...@apache.org>.
tsreaper merged PR #2260:
URL: https://github.com/apache/incubator-paimon/pull/2260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org