You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "vttranlina (via GitHub)" <gi...@apache.org> on 2025/01/07 04:15:00 UTC
[PR] JAMES-3754 - Fix IMAP LIST EXTENSION - return incorrect list response when SUBCRIBED in request option with shared mailbox namespace query [james-project]
vttranlina opened a new pull request, #2585:
URL: https://github.com/apache/james-project/pull/2585
The response of list request should not include private mailboxes when query the shared namespace `#user.*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-3754 - Fix IMAP LIST EXTENSION - return incorrect list response when SUBCRIBED in request option with shared mailbox namespace query [james-project]
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #2585:
URL: https://github.com/apache/james-project/pull/2585#discussion_r1904887409
##########
protocols/imap/src/main/java/org/apache/james/imap/processor/ListProcessor.java:
##########
@@ -267,7 +267,7 @@ private List<Triple<MailboxPath, ListResponse, Optional<MailboxMetaData>>> getLi
allSubscribedSearch.stream()
.filter(subscribed -> !listRecursiveMatchPath.contains(subscribed))
- .filter(mailboxQuery::isPathMatch)
+ .filter(searchedResultMap::containsKey)
Review Comment:
It fix issue, But I'm not sure it is a good way or not.
The `mailboxQuery` is alway true for this case.
`MailboxQuery{namespace=Optional[#private], user=Optional.empty, mailboxNameExpression=PrefixedRegex{prefix='', regex='*'}}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-3754 - Fix IMAP LIST EXTENSION - return incorrect list response when SUBCRIBED in request option with other usersnamespace query [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #2585:
URL: https://github.com/apache/james-project/pull/2585#issuecomment-2574757969
CF
```
Location: /org/apache/james/imap/scripts/ListSubscribed.test:120
Expected one of:
\* LIST \(\\HasNoChildren \\Subscribed\) \"\.\" "INBOX"
\* LIST \(\\Subscribed \\NonExistent\) \"\.\" "subscribeNonExistent"
Actual: A04 OK LIST completed.
```
Related. Please investigate @vttranlina
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-3754 - Fix IMAP LIST EXTENSION - return incorrect list response when SUBCRIBED in request option with shared mailbox namespace query [james-project]
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #2585:
URL: https://github.com/apache/james-project/pull/2585#issuecomment-2574365637
Related to method [PathConverter.Default#asMailboxPath](https://github.com/apache/james-project/blob/master/protocols/imap/src/main/java/org/apache/james/imap/main/PathConverter.java#L112)
I see @chibenwa commit message
```
#user shall not include personal mailboxes
filter them out?
(post filtering?)
```
Maybe your already concern it before? any idea for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-3754 - Fix IMAP LIST EXTENSION - return incorrect list response when SUBCRIBED in request option with other usersnamespace query [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael merged PR #2585:
URL: https://github.com/apache/james-project/pull/2585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org