You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/05/02 18:53:59 UTC

[GitHub] jerrypeng commented on a change in pull request #1708: Refactor functions to use Sink interface

jerrypeng commented on a change in pull request #1708: Refactor functions to use Sink interface
URL: https://github.com/apache/incubator-pulsar/pull/1708#discussion_r185602541
 
 

 ##########
 File path: pulsar-connect/core/src/main/java/org/apache/pulsar/connect/core/Sink.java
 ##########
 @@ -45,5 +45,5 @@
      * @param value output value
      * @return Completable future fo async publish request
      */
-    CompletableFuture<Void> write(T value);
-}
\ No newline at end of file
+    CompletableFuture<Void> write(T value) throws Exception;
 
 Review comment:
   I agree. I will change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services