You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by vijayaguru <vi...@collab.net> on 2010/08/02 17:45:37 UTC

Export with --native-eol is not applied to file externals

Hi,

This is the follow up of issue reported in [1] . Export with
--native-eol option did not work with externals before. Bert fixed it in
r966747.It works fine for directory externals. But file externals are
facing the issue mentioned in the link.

Herewith attached the script that reproduces the problem.

[1] - http://svn.haxx.se/dev/archive-2010-07/0427.shtml


Thanks & Regards,
Vijayaguru

Re: [PATCH] Export with --native-eol is not applied to file externals

Posted by Kannan R <ka...@collab.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 03 August 2010 02:34 AM, Kannan R wrote:
> On Monday 02 August 2010 11:15 PM, vijayaguru wrote:
>> Hi,
>
>> This is the follow up of issue reported in [1] . Export with
>> --native-eol option did not work with externals before. Bert
>> fixed
> it in
>> r966747.It works fine for directory externals. But file externals
>> are facing the issue mentioned in the link.
>
>> Herewith attached the script that reproduces the problem.
>
>> [1] - http://svn.haxx.se/dev/archive-2010-07/0427.shtml
>
>
>
>
> Attached herewith is the patch to resolve the above issue.
>
> [[[ Log: Export with `--native-eol' doesn't work for now unlike
> directory externals.
>
> * subversion/libsvn_client/externals.c
> (handle_external_item_change): Make the `--native-eol' work for
> export of file externals by passing the argument obtained, missed
> in r966747.
>
>
> Found by: Vijayaguru G <vi...@collab.net> Patch by: Kannan R
> <ka...@collab.net> ]]]
>
>
>

Adding the [PATCH] tag, where the patch is found in the previous post [1].

[1] - http://svn.haxx.se/dev/archive-2010-08/0054.shtml

- -- 
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJMVzZIAAoJELQAaYkQr+e71AYIAKdzigd7ISEvMb4nbNFdhySe
cI14fSmQq3+monGiITpOdd7Ug3qcTBhLuZ/WaZUhry1hpkNeRuhoXR82ljBZ3pnp
yN0BBFnzktCAOy61LDi372mJoOee3xkXDlPOJsjSDjGEwn0W1Em2w+WrEZtCIwCy
TjYta3RRLka2xP1mEDA4aMxoQrt/CZG/Y/GPt/Nx5dTXpTejpuu9GZ/VbscEHiQZ
rVEtSDjNdpsNf4EZBwShNiVJytH+0eAwy7GvoNTLniKR03sGJakleC+OQKGxnYJv
kd3Vr5Iy+eMxFavIzs1kUdemVvdbAljhTPcOfUjnI29MlKqg7P5hHlDVrH7XU0Y=
=EAFr
-----END PGP SIGNATURE-----

RE: Export with --native-eol is not applied to file externals

Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: Kannan R [mailto:kannanr@collab.net]
> Sent: maandag 2 augustus 2010 23:05
> To: dev@subversion.apache.org
> Cc: Vijayaguru Guruchave
> Subject: Re: Export with --native-eol is not applied to file externals
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Monday 02 August 2010 11:15 PM, vijayaguru wrote:
> > Hi,
> >
> > This is the follow up of issue reported in [1] . Export with
> > --native-eol option did not work with externals before. Bert fixed it
> in
> > r966747.It works fine for directory externals. But file externals are
> > facing the issue mentioned in the link.
> >
> > Herewith attached the script that reproduces the problem.
> >
> > [1] - http://svn.haxx.se/dev/archive-2010-07/0427.shtml

Thanks, applied this patch in r981757.

	Bert

Re: Export with --native-eol is not applied to file externals

Posted by Kannan R <ka...@collab.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 02 August 2010 11:15 PM, vijayaguru wrote:
> Hi,
>
> This is the follow up of issue reported in [1] . Export with
> --native-eol option did not work with externals before. Bert fixed it in
> r966747.It works fine for directory externals. But file externals are
> facing the issue mentioned in the link.
>
> Herewith attached the script that reproduces the problem.
>
> [1] - http://svn.haxx.se/dev/archive-2010-07/0427.shtml
>
>
>

Attached herewith is the patch to resolve the above issue.

[[[
  Log:
   Export with `--native-eol' doesn't work for now unlike directory
   externals.

  * subversion/libsvn_client/externals.c
     (handle_external_item_change): Make the `--native-eol' work for
      export of file externals by passing the argument obtained, missed
      in r966747.


  Found by: Vijayaguru G <vi...@collab.net>
  Patch by: Kannan R <ka...@collab.net>
]]]



- -- 
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJMVzLtAAoJELQAaYkQr+e71l4H/2MxRCXkpWC49y/es6aZPOBz
TOZbMzkQBjWJmFJq+uXyN+Gyw2KC2QHXQhuGjTs+V6INNHUMHcN5sJjQWMf8ENqv
Nn5ASXAWOmJnv4K+DAv6kN5CDjHEH2Of0lAVxK7OvZtJKYNQsTaJY9+BfUOiy9at
LRxnQJ4v4218qjCZzp3VzPFKEXjZUQZukd1W8mUrjx4Y/CqIYXzYcaO1NWakEWMr
0u9EQnh43eB35rVWMlTSax+BEMj9zqOiXSJGM6qQtp5jwV6aZYU9qpg47RZNwtsA
YD4bVbqsiwNEvaFnszG5GH0zpL+jqkG0eYusiWzvIVp7ZdQK5D/bsTbOt6d+hlQ=
=uy0V
-----END PGP SIGNATURE-----